Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[router] Batch writing error handling #4589

Open
JordiSubira opened this issue Jul 31, 2024 · 1 comment
Open

[router] Batch writing error handling #4589

JordiSubira opened this issue Jul 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@JordiSubira
Copy link
Contributor

Currently the BR discards the packet that cause an error on the WriteBatch operation https://github.com/scionproto/scion/blob/v0.11.0/router/dataplane.go#L959-L963. This was introduced by #4351 and discussed here. As discussed, it isn't trivial to handle any potential errors, but perhaps we can handle some, e.g., if we get this type of error err": "write udp [fd00:f00d:cafe::7f00:12]:31004: sendmmsg: network is unreachable"} we could handle it and generate the appropriate SCMP Destination Unreachable error which would be useful for the remote sender to understand that the SCION host she/he cannot use such a path to reach the destination host.

@JordiSubira JordiSubira added the bug Something isn't working label Jul 31, 2024
@jiceatscion
Copy link
Contributor

One other SCMP error that we SHOULD return but don't: Packet Too Big
That's the only available way to discover MTU issues and we don't enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants