Skip to content

Commit 115500f

Browse files
committed
Merge master into branch
2 parents a3ab987 + 2321839 commit 115500f

38 files changed

+847
-489
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Steps to reproduce the behavior
15+
16+
**Expected behavior**
17+
A clear and concise description of what you expected to happen.
18+
19+
**Screenshots**
20+
If applicable, add screenshots to help explain your problem.
21+
22+
**System**
23+
- OS: [e.g. iOS]
24+
- Version [e.g. 22]
25+
- SCIP version
26+
- How did you install `pyscipopt`?
27+
28+
**Additional context**
29+
Add any other context about the problem here.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Additional context**
17+
Add any other context or screenshots about the feature request here.

.github/workflows/coverage.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@ name: Run tests with coverage
22
env:
33
version: 8.0.3
44

5-
# runs on branches and pull requests; doesn't run on tags.
65
on:
76
push:
87
branches:
9-
master
8+
- 'master'
109
pull_request:
10+
branches:
11+
- 'master'
1112

1213
jobs:
1314

.github/workflows/integration-test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ env:
77
on:
88
push:
99
branches:
10-
- master
11-
pull_request:
10+
- 'master'
1211

1312
jobs:
1413

CHANGELOG.md

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,30 @@
22

33
## Unreleased
44
### Added
5-
- Add SCIP functions SCIPconsGetNVars, SCIPconsGetVars
6-
- Add SCIP functions SCIPchgCoefLinear, SCIPaddCoefLinear and SCIPdelCoefLinear
7-
- Add SCIP function SCIPgetSolTime and wrapper getSolTime
8-
- Add convenience methods relax and getVarDict
9-
- Add SCIP functions hasPrimalRay, getPrimalRay, getPrimalRayVal
5+
- Add getConshdlrName to class Constraint
106
### Fixed
7+
### Changed
8+
### Removed
9+
10+
## 4.4.0 - 2023-12-04
11+
### Added
12+
- Added all event types and tests for checking them
13+
- Added SCIP functions SCIPconsGetNVars, SCIPconsGetVars
14+
- Added SCIP functions SCIPchgCoefLinear, SCIPaddCoefLinear and SCIPdelCoefLinear
15+
- Added SCIP function SCIPgetSolTime and wrapper getSolTime
16+
- Added convenience methods relax and getVarDict
17+
- Added SCIP functions hasPrimalRay, getPrimalRay, getPrimalRayVal
18+
### Fixed
19+
- Fixed mistake with outdated values for several enums
20+
- Correctly set result, lowerbound in PyRelaxExec
1121
- Fixed typo in documentation of chgRhs
1222
- Pricer plugin fundamental callbacks now raise an error if not implemented
1323
- Brachrule plugin fundamental callbacks now raise an error if not implemented
1424
- Fixed segmentation fault when accessing the Solution class directly
1525
- Changed getSols so that it prints solutions in terms of the original variables
1626
- Fixed error message in _checkStage
1727
### Changed
28+
- Made it so SCIP macros are used directly, instead of being manually inputted.
1829
- Improved error message when using < or > instead of <= or >=
1930
### Removed
2031
- Removed double declaration of SCIPfindEventhdlr

src/pyscipopt/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
__version__ = '4.3.0'
1+
__version__ = '4.4.0'
22

33
# required for Python 3.8 on Windows
44
import os

src/pyscipopt/relax.pxi

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ cdef class Relax:
2828
'''callls execution method of relaxation handler'''
2929
print("python error in relaxexec: this method needs to be implemented")
3030
return{}
31-
31+
3232

3333
cdef SCIP_RETCODE PyRelaxCopy (SCIP* scip, SCIP_RELAX* relax) with gil:
3434
return SCIP_OKAY
@@ -73,6 +73,8 @@ cdef SCIP_RETCODE PyRelaxExec (SCIP* scip, SCIP_RELAX* relax, SCIP_Real* lowerbo
7373
cdef SCIP_RELAXDATA* relaxdata
7474
relaxdata = SCIPrelaxGetData(relax)
7575
PyRelax = <Relax>relaxdata
76-
PyRelax.relaxexec()
77-
return SCIP_OKAY
78-
76+
result_dict = PyRelax.relaxexec()
77+
assert isinstance(result_dict, dict), "relaxexec() must return a dictionary."
78+
lowerbound[0] = result_dict.get("lowerbound", <SCIP_Real>lowerbound[0])
79+
result[0] = result_dict.get("result", <SCIP_RESULT>result[0])
80+
return SCIP_OKAY

0 commit comments

Comments
 (0)