You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation of DTChecker has several "this needs to be done exactly like this" comments. On the contrary, some of these may be possible to simplify/streamline. However, this code has grown to account for actual usage in existing codebases, so this maintenance has a prerequisite of correctly testing at least numpy and scipy documentation.
The text was updated successfully, but these errors were encountered:
As a data point, I tried removing (in #173) the want == got check from https://github.com/scipy/scipy_doctest/blob/main/scipy_doctest/impl.py#L395 (which is where "this should be done exactly as written" comment comes from). It immediately causes some breakage in NumPy when IIRC comparing non-trivial dtypes: those are not handled by allclose and the check feel down to the literal white-space sensitive vanilla doctest comparison.
The implementation of DTChecker has several "this needs to be done exactly like this" comments. On the contrary, some of these may be possible to simplify/streamline. However, this code has grown to account for actual usage in existing codebases, so this maintenance has a prerequisite of correctly testing at least numpy and scipy documentation.
The text was updated successfully, but these errors were encountered: