-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: Better way to pass secret data into container #91
Comments
from an openshift perspective the better approach is to use Secrets and have the image read the password from the mounted secret. (and in a non-openshift/k8s environment, users could still mount to the secret path themselves to provide the password/config) but as you say, it should be in addition to environment. |
@bparees I guess you mean this feature: https://docs.openshift.com/enterprise/3.0/dev_guide/secrets.html Without deeper knowledge of OpenShift I'm not sure whether I understand it correctly, what happens from image PoV in this case? Is the file volume-mounted into there? @mfojtik This might be the summary of unfinished work related: moby/moby#13490 |
It also depends on what you consider secret. For things like MYSQL_PASSWORD In OpenShift we use secrets to store things like SSL certificates, tokens -- Michal On Wed, Sep 9, 2015 at 8:48 AM, Honza Horak [email protected]
Michal Fojtik <[email protected] [email protected]> |
@hhorak yes the file gets volume-mounted there and the image can reference it. |
Current way of passing passwords using
-e
is not the best one, since even root (or whoever can talk to docker socket) should be able to read the passwords. However, with-e
way, even if the variable is unset inside the container, one can read the value fromdocker inspect
output.This issue is meant to track an RFE to be able to specify password somehow differently, maybe in addition to the current
-e
option. This new way shouldn't allow to see the password even for docker admin/root.The text was updated successfully, but these errors were encountered: