Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove run_master_restart_test tests #509

Closed
phracek opened this issue Apr 24, 2023 · 5 comments
Closed

Remove run_master_restart_test tests #509

phracek opened this issue Apr 24, 2023 · 5 comments

Comments

@phracek
Copy link
Member

phracek commented Apr 24, 2023

Container platform

Podman/Docker

Version

No response

OS version of the container image

RHEL 8, RHEL 9, CentOS Stream 9

Bugzilla, Jira

No response

Description

It looks like the tests `` is failing on several platforms. I would remove it.

See logs here: #507

 [PASSED] for 'postgresql-container_tests' run_replication_test (00:00:06)
 [FAILED] for 'postgresql-container_tests' run_master_restart_test (00:01:13)
 [PASSED] for 'postgresql-container_tests' run_doc_test (00:00:01)

Reproducer

No response

@zmiklank
Copy link
Contributor

I think that more elaborate explanation on why to remove this test is needed. If we would remove all tests just because they are failing then we do not really need any tests at all.

Could you please explain why specifically this test should be removed instead of being fixed?

@fila43
Copy link
Member

fila43 commented May 2, 2023

From my point of view. It tests unsupported functionality. And it would cost a lot of afford to investigate it. I've spent some time debugging it but without any success. It fails randomly. I have some thoughts on catching it, but I am unsure whether it is worth it.

@zmiklank
Copy link
Contributor

zmiklank commented May 2, 2023

From my point of view. It tests unsupported functionality. And it would cost a lot of afford to investigate it. I've spent some time debugging it but without any success. It fails randomly. I have some thoughts on catching it, but I am unsure whether it is worth it.

Hi, thank for your reply. Is there somewhere a list of supported functionality? So we could enclose it in the commit message in proceeding PR?

@fila43
Copy link
Member

fila43 commented May 2, 2023

Here, we have information about replication. It's just a proof-of-concept functionality. That's why I interpret it as unsupported.

@phracek
Copy link
Member Author

phracek commented Sep 15, 2023

This issues is resolved by #510. Closing.

@phracek phracek closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants