Fix upgrade and migration tests #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCL should be NOOP in RHEL8+, but due to wrong check of VERSION_ID -lt 8, which does not evaluate correctly when VERSION_ID is '9.4', the paths are incorrectly set to /opt... in some versions of RHEL, not in Fedora.
|
[test] |
The set is different on different distro versions, so let's not let docker pull fail, instead be more cautious about what versions we actually expect to exist.
|
[test] |
hhorak
force-pushed
the
remove-scl-check
branch
from
e1ab1af
to
6fb5e70
Compare
|
[test] |
Previous epel7 mirror URL does not work after RHEL7 EOL, but the same RPM is still available in koji. A test for a correct download should hopefully make the download failure easier to debug in the future. The check functions did not actually wait when the first podman exec failed, so in case the server was not up soon, the check failed too early. It is ok to wait for the server a bit, so let's repeat the podman exec with psql until it succeeds or 30s pass.
hhorak
force-pushed
the
remove-scl-check
branch
from
6fb5e70
to
7835b16
Compare
|
[test] |
|
A comment about pagila - we should rather download directly from github (issue to be created). |
phracek
approved these changes
Sep 4, 2024
Reported as #589 |
There was a problem hiding this comment.
The reason why I don't think this is a good idea long term (and why the separate issue was created) is that since we are linking to a specific version on the repository that is not supported anymore, the link can stop working anytime.
Silently missing, this is resolved with the check that the download succeeded, which is a great addition!
There was a problem hiding this comment.
I have mentioned this change in the Google doc to keep it updated.
bdunne
added a commit
to bdunne/container-postgresql
that referenced
this pull request
Oct 28, 2024
sclorg/postgresql-container#588 https://gitlab.com/redhat/centos-stream/rpms/postgresql/-/commit/ced30efb935315a3ac323a526671010d6a50f1d7 ERROR: pkgconf-pkg-config-1.7.3-10.el9.x86_64 postgresql-13.16-1.el9.x86_64 postgresql-contrib-13.16-1.el9.x86_64 postgresql-private-libs-13.16-1.el9_4.x86_64 postgresql-server-13.16-1.el9.x86_64 protobuf-c-1.3.3-13.el9.x86_64 setup-2.13.7-10.el9.noarch shadow-utils-2:4.9-9.el9.x86_64 uuid-1.6.2-55.el9.x86_64 Complete! Found VERSION 13 Last metadata expiration check: 0:00:12 ago on Mon Oct 28 15:14:16 2024. Dependencies resolved. ================================================================================ Package Architecture Version Repository Size ================================================================================ Reinstalling: tzdata noarch 2024a-1.el9 ubi-9-baseos-rpms 842 k Transaction Summary ================================================================================ Total download size: 842 k Installed size: 1.6 M Downloading Packages: tzdata-2024a-1.el9.noarch.rpm 5.1 MB/s | 842 kB 00:00 -------------------------------------------------------------------------------- Total 5.0 MB/s | 842 kB 00:00 Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Reinstalling : tzdata-2024a-1.el9.noarch 1/2 Cleanup : tzdata-2024a-1.el9.noarch 2/2 Verifying : tzdata-2024a-1.el9.noarch 1/2 Verifying : tzdata-2024a-1.el9.noarch 2/2 Reinstalled: tzdata-2024a-1.el9.noarch Complete! 47 files removed fixing permissions on '/var/lib/pgsql' directory /usr/libexec/fix-permissions: Error: no such directory '/var/run/postgresql' Usage: /usr/libexec/fix-permissions [--read-only] DIR [DIR ..] Recursively fix permissions on the given directories to allow GID=0 read/write regular files and read/write/execute directories. To run this command, you have to be in the group root=0! Error: building at STEP "RUN dnf -y --disableplugin=subscription-manager --setopt=tsflags=nodocs update && (dnf info postgresql-server); if [ $? == 1 ]; then ARCH=$(uname -m) && dnf -y --setopt=protected_packages= remove redhat-release && dnf -y remove *subscription-manager* && dnf -y install http://mirror.stream.centos.org/9-stream/BaseOS/${ARCH}/os/Packages/centos-stream-release-9.0-24.el9.noarch.rpm http://mirror.stream.centos.org/9-stream/BaseOS/${ARCH}/os/Packages/centos-stream-repos-9.0-24.el9.noarch.rpm http://mirror.stream.centos.org/9-stream/BaseOS/${ARCH}/os/Packages/centos-gpg-keys-9.0-24.el9.noarch.rpm && dnf clean all && rm -rf /var/cache/dnf; fi && { yum -y module enable postgresql:13 || :; } && INSTALL_PKGS="rsync tar gettext bind-utils nss_wrapper postgresql-server postgresql-contrib" && yum -y --setopt=tsflags=nodocs install $INSTALL_PKGS && rpm -V $INSTALL_PKGS && postgres -V | grep -qe "$POSTGRESQL_VERSION\." && echo "Found VERSION $POSTGRESQL_VERSION" && (yum -y reinstall tzdata || yum -y update tzdata ) && yum -y clean all --enablerepo='*' && localedef -f UTF-8 -i en_US en_US.UTF-8 && chmod -R g+w /etc/pki/tls && test "$(id postgres)" = "uid=26(postgres) gid=26(postgres) groups=26(postgres)" && mkdir -p /var/lib/pgsql/data && /usr/libexec/fix-permissions /var/lib/pgsql /var/run/postgresql": while running runtime: exit status 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept in a singe PR because all changes are related to the upgrade and migration tests (except the
/var/run/->/run/change that was necessary to make the image build at all):The SCL should be NOOP in RHEL8+, but due to wrong check of VERSION_ID -lt 8, which does not evaluate correctly when VERSION_ID is '9.4', the paths are incorrectly set to /opt... in some versions of RHEL, not in Fedora.
This is rather improvement to not try pulling images that do not exist. The set is different on different distro versions, so let's not let docker pull fail, instead be more cautious about what versions we actually expect to exist.
Previous epel7 mirror URL does not work after RHEL7 EOL, but the same RPM is still available in koji. A test for a correct download should hopefully make the download failure easier to debug in the future.
The check functions did not actually wait when the first podman exec failed, so in case the server was not up soon, the check failed too early. It is ok to wait for the server a bit, so let's repeat the podman exec with psql until it succeeds or 30s pass.