Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker with podman in s2i usage #56

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Jul 1, 2019

SSIA

@phracek
Copy link
Member

phracek commented Apr 25, 2023

@hhorak Do we really need to mention podman in s2i/bin/run script? In case of package podman-docker is installed, then this is not needed. In the rest of all containers, we use docker. Can we close this issue?

@zmiklank
Copy link
Contributor

@hhorak Do we really need to mention podman in s2i/bin/run script? In case of package podman-docker is installed, then this is not needed. In the rest of all containers, we use docker. Can we close this issue?

I know that I am not hhorak, but I think we should indeed use podman in docs or usage information because we use podman internally (except for rhel7, centos7) even thoug we call it with docker alias. Podman, not docker, is also the supported container engine for RHEL releases.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phracek
Copy link
Member

phracek commented Apr 18, 2024

[test]

@zmiklank
Copy link
Contributor

I've rebased this on master so that we can run tests.
[test]

@zmiklank
Copy link
Contributor

And added distgen-generated content.

[test]

@zmiklank zmiklank merged commit f638eb9 into sclorg:master Apr 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants