Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring post-validated block types #6

Open
sco1 opened this issue Oct 29, 2022 · 0 comments
Open

Consider refactoring post-validated block types #6

sco1 opened this issue Oct 29, 2022 · 0 comments
Labels
internals Changes to things that aren't user-facing

Comments

@sco1
Copy link
Owner

sco1 commented Oct 29, 2022

The typing is a mess. Currently, typing for serialization uses the types defined by the parser which are broader than what comes out of the validator. This leads to a lot of type narrowing that isn't necessary because the validation step has thrown out values that aren't acceptable for each parameter.

I think it's possible to narrow the post-validation types into something structural, so let's look at that soon.

@sco1 sco1 added the internals Changes to things that aren't user-facing label Oct 29, 2022
@sco1 sco1 changed the title Consider refactoring post-validated block types into protocols Consider refactoring post-validated block types Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Changes to things that aren't user-facing
Projects
None yet
Development

No branches or pull requests

1 participant