Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning - January 2018 #68

Closed
paulkaplan opened this issue Dec 8, 2017 · 1 comment
Closed

Deprecation warning - January 2018 #68

paulkaplan opened this issue Dec 8, 2017 · 1 comment
Assignees
Milestone

Comments

@paulkaplan
Copy link
Contributor

Just started getting this deprecation warning

[Deprecation] GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.

@ericrosenbaum can you determine if we want the instantaneous behavior (in which case I guess we keep the setter the way it is) or if we want a smoothed behavior (in which case we should switch to using setTargetAtTime)?

I'm adding this to the December milestone just to stay ahead of it, but I do not think (judging from the warning) that it would cause any buggy behavior if we let it be. But I'd like to get a decision on the books this month just so we know where we stand.

@paulkaplan paulkaplan added this to the Dec 20 milestone Dec 8, 2017
@ericrosenbaum
Copy link
Collaborator

ericrosenbaum commented Dec 8, 2017

We’re using gain.value to set the volume and in the pan effect. Using that setTargetAtTime approach will help make sure those sound good and not clicky. Also we can use it in other places to prevent clicks (as in #42)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants