Comment position and "Save Now" issues

[griffpatch]

Expected Behavior

Comments stay were you last saved them and the editor does not say "Save Now" upon loading up.

Actual Behavior

As soon as your project contains a comment attached to a block, and you reload the project after saving, it will always say "Save Now" straight away.

Also the position of the comment blocks are not persisted when you move them by dragging their parent block around. They only save if you move the actual comment by hand.

Steps to Reproduce

Create a new project add a block
Right click block and add a comment
Drag block (not comment) to somewhere else on the screen
save project

reload project and comment will appear back where it was first created, not relative to new block position.
Also, 'Save Now' wording will have appeared on menu bar.

Operating System and Browser

Windows 10, chrome.

[apple502j]

Duplicate of #4776 which is duplicate of scratchfoundation/scratch-blocks#1566

[griffpatch]

Comments have not saved their locations for over 2 years! Lol - no wonder no one comments their code any longer in scratch... That's a shame. Deserves a fix I think!

…

On Mon, 29 Jun 2020, 13:47 apple502j, ***@***.***> wrote: Duplicate of #4776 <#4776> which is duplicate of scratchfoundation/scratch-blocks#1566 <scratchfoundation/scratch-blocks#1566> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5948 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTM3PV2Q5A5RMPUJKI3MKLRZCEOZANCNFSM4OLC7WLA> .

[griffpatch]

Has it also been reported that comments simply disappear if you switch to costume tab and back to code editor a few times?

…

On Mon, 29 Jun 2020 at 15:01, Andrew Griffin ***@***.***> wrote: Comments have not saved their locations for over 2 years! Lol - no wonder no one comments their code any longer in scratch... That's a shame. Deserves a fix I think! On Mon, 29 Jun 2020, 13:47 apple502j, ***@***.***> wrote: > Duplicate of #4776 <#4776> > which is duplicate of scratchfoundation/scratch-blocks#1566 > <scratchfoundation/scratch-blocks#1566> > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#5948 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABTM3PV2Q5A5RMPUJKI3MKLRZCEOZANCNFSM4OLC7WLA> > . >

[apple502j]

List of Issues with Comments:

• In-project comments not saving #5638 - A bug with costume tab is described there, but no repro.
• The comments didn`t show at the right place when project loaded #4776 - Issues with moving blocks with comments
• Duplicated sprites lose their comments #3687 - Duplicated sprites lose comments. Gonna check if I can still repro
• Block comments appear later than workspace comments when switching sprites #2299 - Block comments appear after floating comments
• Switching to a sprite that has a block comment triggers a project changed state scratch-vm#2027 - Projects save without changes when block comment is loaded
• Changing a block or workspace comment doesn't trigger project changed until the comment is un-focused scratch-vm#2026 - Projects don't save when block comment is edited (before un-focusing
• Comments attached to variable blocks are altogether lost upon saving scratch-vm#1893 - Comments attached to variable blocks disappear after re-load
• Comments attached to custom block definitions in 2.0 do not attach to correct blocks in 3.0 scratch-vm#1499 - Issues with deserializing sb2 with comments attached to custom blocks
• Saving and loading a project w/more than one comment attached to single block (imported from 2.0) fails scratch-vm#1257 - Crash with deserializing sb2 with multiple comments attached to a single block
• Comments in imported project can be removed using undo scratch-blocks#1973 - Undo can remove block comments from blocks just after opening
• Undoing removing a block which had a comment attached does not restore the comment scratch-blocks#1936 - Undoing removing blocks with comments attached do not restore comments
• Comment from 2.0 project getting imported attached to the wrong block scratch-blocks#1705 - Issues with deserializing sb2 with comments
• Workspace comments are not being imported scratch-sb1-converter#3 - Issues with deserializing sb with non-block comments
• SB1 Projects with Comments Don't Load scratch-sb1-converter#36 - Crash with deserializing sb with comments

[apple502j]

Note: #2299 is probably causing scratchfoundation/scratch-vm#2027 and scratchfoundation/scratch-blocks#1973

[Explosion-Scratch]

@griffpatch I can reproduce the comment disappearance. Mac 10.13.6 Safari.

[BryceLTaylor]

Closing as duplicate of scratchfoundation/scratch-blocks#1566