Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 264983948 doesn't load #61

Closed
apple502j opened this issue Nov 29, 2018 · 7 comments · Fixed by #63
Closed

Project 264983948 doesn't load #61

apple502j opened this issue Nov 29, 2018 · 7 comments · Fixed by #63
Assignees
Labels
Milestone

Comments

@apple502j
Copy link

https://scratch.mit.edu/projects/264983948/
https://llk.github.io/scratch-gui/develop/#264983948

I saw Oops in 3.0, with vm error Document does not appear to be SVG.

@apple502j
Copy link
Author

@thisandagain thisandagain added bug Something isn't working compatibility critical labels Nov 29, 2018
@thisandagain thisandagain added this to the December 2018 milestone Nov 29, 2018
@thisandagain
Copy link
Contributor

/cc @kchadha @ktbee

@apple502j
Copy link
Author

yokobond on Twitter said that ungrouping the SVG fixes this. I tried that and it's working!
Maybe a good clue.
https://twitter.com/yokobond/status/1071926418517352448

@paulkaplan paulkaplan assigned paulkaplan and unassigned fsih Dec 10, 2018
@paulkaplan
Copy link
Contributor

This is a problem we've seen before, some (apparently common) svg export mode from Illustrator includes undeclared entities in the SVG (things like &ns_extends;, &ns_ai;) that crash the DOMParser. We can provide those entity declarations manually, or find and replace the entities with their real link values. It is super annoying because all those entities do is reference namespace strings that don't do anything anyway...

@fsih
Copy link
Contributor

fsih commented Dec 11, 2018

@paulkaplan I guess you probably know already but that sounds like scratchfoundation/scratch-gui#3534 and the text you can add to make the svg work is here: scratchfoundation/scratch-gui#3534 (comment)

@ktbee
Copy link
Contributor

ktbee commented Dec 11, 2018

FYI as part of a fix for scratchfoundation/scratch-gui#3534 and based on a Slack conversation with @thisandagain and @kchadha , I'm adding a backup solution for broken SVGs where we use the builtin defaultVector.svg asset in scratch-storage to replace broken SVGs instead of just throwing an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants