Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SvgRenderer.loadString is synchronous, disabling certain fixups #89

Open
adroitwhiz opened this issue Apr 29, 2019 · 0 comments
Open

SvgRenderer.loadString is synchronous, disabling certain fixups #89

adroitwhiz opened this issue Apr 29, 2019 · 0 comments

Comments

@adroitwhiz
Copy link
Contributor

Currently, SvgRenderer.loadString and all methods that call it are synchronous. However, certain fixups (e.g. measuring elements) require asynchronous function calls. In order to better support Scratch 2.0 SVGs, SvgRenderer.loadString must be made asynchronous, which has implications for the rest of the Scratch codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adroitwhiz