Merge pull request #53 from evemf/fix/php-notice-caused-by-deprecated-screen-icon

scribu · web-flow · commit d35d5126c6d3 · 2020-03-15T20:51:58.000Z
Fix for PHP notice caused by deprecated screen_icon.
diff --git a/AdminPage.php b/AdminPage.php
@@ -186,7 +186,6 @@ protected function page_help() { }
 	 */
 	protected function page_header() {
 		echo "<div class='wrap'>\n";
-		screen_icon( $this->args['screen_icon'] );
 		echo html( 'h2', $this->args['page_title'] );
 	}
 
@@ -510,7 +509,6 @@ private function check_args() {
 			'toplevel'              => '',
 			'position'              => null,
 			'icon_url'              => '',
-			'screen_icon'           => '',
 			'parent'                => 'options-general.php',
 			'capability'            => 'manage_options',
 			'menu_title'            => $this->args['page_title'],
@@ -581,4 +579,3 @@ public function _action_link( $links ) {
 		return $links;
 	}
 }
-

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,6 @@ protected function page_help() { }`
`186`	`186`	`*/`
`187`	`187`	`protected function page_header() {`
`188`	`188`	`echo "<div class='wrap'>\n";`
`189`		`- screen_icon( $this->args['screen_icon'] );`
`190`	`189`	`echo html( 'h2', $this->args['page_title'] );`
`191`	`190`	`}`
`192`	`191`
`@@ -510,7 +509,6 @@ private function check_args() {`
`510`	`509`	`'toplevel' => '',`
`511`	`510`	`'position' => null,`
`512`	`511`	`'icon_url' => '',`
`513`		`- 'screen_icon' => '',`
`514`	`512`	`'parent' => 'options-general.php',`
`515`	`513`	`'capability' => 'manage_options',`
`516`	`514`	`'menu_title' => $this->args['page_title'],`
`@@ -581,4 +579,3 @@ public function _action_link( $links ) {`
`581`	`579`	`return $links;`
`582`	`580`	`}`
`583`	`581`	`}`
`584`		`-`