Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing default loglevel for ScyllaDB #2374

Closed
mflendrich opened this issue Feb 4, 2025 · 3 comments
Closed

Allow changing default loglevel for ScyllaDB #2374

mflendrich opened this issue Feb 4, 2025 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/from-migration Indicates that this issue is a copy of a corresponding issue mentioned in the description. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mflendrich
Copy link
Collaborator

Issue originally authored by tnozicka as #2011

As a user I'd like to change the default loglevel for all ScyllaDB components using --default-log-level flag in spec.scyllaArgs.

While we allow adding extra flags with spec.scyllaArgs, when configured with scyllaArgs: "--default-log-level=trace" the ScyllaDB startup scripts fail because they have hard wired the flag with info level and it can be defined only once

Scylla version 6.0.1-0.20240612.bc89aac9d017 with build-id e845b7c6530ae1385e7bb3b7def09b4ffdf191c2 starting ...
command used: "/usr/bin/scylla --log-to-syslog 0 --log-to-stdout 1 --default-log-level info --network-stack posix --developer-mode=1 --smp 1 --overprovisioned --listen-address 0.0.0.0 --rpc-address 0.0.0.0 --seed-provider-parameters seeds=10.85.5.102 --broadcast-address 10.85.5.102 --broadcast-rpc-address 10.85.5.102 --alternator-address 0.0.0.0 --blocked-reactor-notify-ms 999999999 --default-log-level=trace --prometheus-address=0.0.0.0"
pid: 58
parsed command line options: [log-to-syslog, (positional) 0, log-to-stdout, (positional) 1, default-log-level, (positional) info, network-stack, (positional) posix, developer-mode: 1, smp, (positional) 1, overprovisioned, listen-address: 0.0.0.0, rpc-address: 0.0.0.0, seed-provider-parameters: seeds=10.85.5.102, broadcast-address: 10.85.5.102, broadcast-rpc-address: 10.85.5.102, alternator-address: 0.0.0.0, blocked-reactor-notify-ms, (positional) 999999999, default-log-level: trace, prometheus-address: 0.0.0.0]
error: option '--default-log-level' cannot be specified more than once

Try --help.
@mflendrich mflendrich added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 4, 2025
@mflendrich mflendrich added the lifecycle/from-migration Indicates that this issue is a copy of a corresponding issue mentioned in the description. label Feb 4, 2025
@mflendrich
Copy link
Collaborator Author

Closing as duplicate. We should think about logging from the user's perspective holistically, including both individual clusters and the operator machinery - will clarify this distinction and track as one issue.

@rzetelskik
Copy link
Member

Closing as duplicate. We should think about logging from the user's perspective holistically, including both individual clusters and the operator machinery - will clarify this distinction and track as one issue.

But this issue is a tracker for making changing the default database loglevel possible? Seems like a separate issue to me, as it's not even on us to fix this.

@mflendrich
Copy link
Collaborator Author

Looking at the two problem statements taken verbatim from the two issues:

I'd like to change the default loglevel for all ScyllaDB components using --default-log-level flag in spec.scyllaArgs

Loglevel of particular components should be configurable through ScyllaOperatorConfig.

there's either overlap between the two (that I'm trying to untangle), or some implicit context that makes them different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/from-migration Indicates that this issue is a copy of a corresponding issue mentioned in the description. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants