Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Indication of the type of capture (amp, full rig etc.) in the NAM plugin gui #439

Open
IsaakCode opened this issue Feb 21, 2024 · 2 comments
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@IsaakCode
Copy link

Is your feature request related to a problem? Please describe.
I have various profiles downloaded from ToneHunt and other reposities saved to a directory. There is no indication whether the profile covers the amp only or the full-rig when I load it into NAM. There is also typically no clear indication in the file name of the profile, the info is only available in the repository.

Describe the solution you'd like
A visual indicator / text field in the NAM gui giving away the type of profile (amp, full rig, outboard device, pedal). This probably requires that the profile file contains that info. Maybe in the NAM Trainer an obligatory selection can be added to indicate the type of profile, with that info made visible in the NAM plugin?

This could also be used further down the line for a preset browser, that allows selection of profiles in the user library according to type.

Alternative
Connect NAM plugin with the ToneHunt repository via an included file browser that retrieves and displays the profile type from the ToneHunt database and which allows downloads of profiles directly from within NAM plugin to a specified user directory.

@IsaakCode IsaakCode added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet labels Feb 21, 2024
@sdatkinson
Copy link
Owner

TL,DR:

  • Some models do have the metadata to do this, but it's not mandatory to provide and I won't make it so.
  • I'm open to implementing this into the plugin.

Metadata is currently optional and easy to provide using e.g. the Colab trainer:

image

As well as the GUI trainer:

image

I could imagine something like one of several icons lighting up in the plugin based on what kind of model the file is annotated as in its metadata (or a question mark if it's not provided).

To do this, I'd need some image artifacts with enabled/disabled versions similar to the amp and IR icons (e.g. IRIconOn.svg / IRIconOff.svg). Probably a pedal, amp, cab, preamp(?), and studio(?).

Putting this all on the left side where ModelIcon.svg lives currently makes sense to me, but I'm open to suggestions.

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Mar 2, 2024
@38github
Copy link

38github commented Mar 8, 2024

It would be "cool" if the IR is inactivated when a full_rig is loaded and activated when a non full_rig is loaded. It would be a good idea to have an option to disable that behaviour though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants