Adds Maximum Attempt Limit to Submit Flag #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR for issue #371 |
api/submit.go
Outdated
| @@ -136,6 +146,40 @@ func submitFlagHandler(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| tryStatus, err := database.GetUserPreviousTriesStatus(user.ID, challenge.ID, challenge.FailSolveLimit) | |||
| @@ -122,6 +124,7 @@ type ChallengePreviewResp struct { | |||
| Tags []string `json:"tags" example:"['pwn','misc']"` | |||
| Assets []string `json:"assets" example:"['image1.png', 'zippy.zip']"` | |||
| AdditionalLinks []string `json:"additionalLinks" example:"['http://link1.abc:8080','http://link2.abc:8081']"` | |||
| PreReqs []string `json:"preReqs" example:"['web-php','simple']"` | |||
| @@ -172,6 +216,7 @@ func submitFlagHandler(c *gin.Context) { | |||
| CreatedAt: time.Time{}, | |||
| UserID: user.ID, | |||
| ChallengeID: challenge.ID, | |||
| Solved: true, | |||
There was a problem hiding this comment.
don't store it for false status. I think there is no need for solved feild
core/config/challenge.go
Outdated
| @@ -150,6 +152,10 @@ func (config *ChallengeMetadata) ValidateRequiredFields() (error, bool) { | |||
| return fmt.Errorf("Name and Flag required for the challenge"), false | |||
| } | |||
|
|
|||
| if config.FailSolveLimit <= 0 { | |||
There was a problem hiding this comment.
if failSolve limit not declared or zero. Make it either negative or infinite
|
|
||
| // Query the database to get the user's solved challenges | ||
| var userChallenges []UserChallenges | ||
| err := Db.Where("user_id = ? AND solved = ?", userID, true).Find(&userChallenges).Error |
| } | ||
|
|
||
| // Create a map to quickly check if a challenge is solved | ||
| solvedChallenges := make(map[string]bool) |
| @@ -173,7 +173,7 @@ func CheckPreviousSubmissions(userId uint, challId uint) (bool, error) { | |||
| DBMux.Lock() | |||
| defer DBMux.Unlock() | |||
|
|
|||
| tx := Db.Where("user_id = ? AND challenge_id = ?", userId, challId).Find(&userChallenges).Count(&count) | |||
| tx := Db.Where("user_id = ? AND challenge_id = ? AND solved = ?", userId, challId, true).Find(&userChallenges).Count(&count) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.