Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Maximum Attempt Limit to Submit Flag #370

Open
wants to merge 19 commits into
base: multiple_servers
Choose a base branch
from
Open

Adds Maximum Attempt Limit to Submit Flag #370

wants to merge 19 commits into from
+616 −829,438

Conversation

Aryan51203
Copy link

No description provided.

@Aryan51203
Copy link
Author

PR for issue #371

This was linked to issues Jan 11, 2025
Maximum Attempt Limit: Users or teams can only submit flags a limited number of times, as specified in the beast.toml file for each challenge. #371
Open
Chained Challenges: Completing a specific challenge will unlock the next part of the challenge. #373
Open
sukhman-sukh
sukhman-sukh reviewed Jan 15, 2025
View reviewed changes
api/submit.go Outdated Show resolved Hide resolved
api/response.go Show resolved Hide resolved
api/submit.go Show resolved Hide resolved
core/config/challenge.go Outdated Show resolved Hide resolved
core/database/challenges.go Outdated Show resolved Hide resolved
core/database/challenges.go Outdated Show resolved Hide resolved
core/database/user.go Show resolved Hide resolved
@sukhman-sukh sukhman-sukh changed the base branch from master to multiple_servers February 4, 2025 17:45
v1bh475u
v1bh475u reviewed Feb 4, 2025
View reviewed changes
core/manager/utils.go Outdated Show resolved Hide resolved
v1bh475u
v1bh475u reviewed Feb 4, 2025
View reviewed changes
core/manager/utils.go Outdated Show resolved Hide resolved
v1bh475u
v1bh475u reviewed Feb 4, 2025
View reviewed changes
core/database/hints.go Outdated Show resolved Hide resolved
v1bh475u
v1bh475u reviewed Feb 4, 2025
View reviewed changes
core/config/challenge.go Outdated Show resolved Hide resolved
@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 4, 2025

@Aryan51203 I have review your commits and suggested some changes. Please go through them.

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

@Aryan51203 Please do these small changes and I guess we are done

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

#370 (comment) this is left

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

LGTM

@sukhman-sukh
Copy link
Contributor

Did you test every feature of this PR with the frontend?

@v1bh475u
Copy link
Contributor

v1bh475u commented Feb 5, 2025

I have only done code review. Please do the testing if you are free.

@sukhman-sukh
Copy link
Contributor

Ok ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1bh475u v1bh475u v1bh475u left review comments

@sukhman-sukh sukhman-sukh sukhman-sukh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Aryan51203 @v1bh475u @sukhman-sukh @SomyaChawla0250 @ayu-ch