Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library interface #87

Open
sandstrom opened this issue Nov 5, 2019 · 0 comments
Open

Library interface #87

sandstrom opened this issue Nov 5, 2019 · 0 comments

Comments

@sandstrom
Copy link
Contributor

Thanks for a great library!

Two thoughts:

  1. It's slightly cumbersome to import the countries. Have you considered adjusting the interface to something like this:
import { lookup } from 'jsvat'; 

let response = lookup('BE0411905847');
// where response would be the current response object
  1. Perhaps there could be a property for groups of countries in the response, e.g. blocs: ['eu'], so one could quickly check if a VAT number is within the EU VAT scheme. Could add more relevant blocks in the future if needed.

Happy to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant