Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why the Helm Chart Release GitHub Action didn't work #97

Open
jessebot opened this issue Nov 20, 2023 · 4 comments
Open

Investigate why the Helm Chart Release GitHub Action didn't work #97

jessebot opened this issue Nov 20, 2023 · 4 comments

Comments

@jessebot
Copy link
Contributor

jessebot commented Nov 20, 2023

We need to investigate why the release didn't show up here:
https://github.com/seaweedfs/seaweedfs-operator/releases

Here's the GitHub Workflow:
https://github.com/seaweedfs/seaweedfs-operator/blob/master/.github/workflows/helm_chart_release.yml

Here's the job where it ran:
https://github.com/seaweedfs/seaweedfs-operator/actions/runs/6921460451/job/18827076156

I will test this on a fork and see what I can surmise. My first inclination is that the perhaps it has to do with one of the following:

  • GitHub Pages is not configured for this repo (example screenshot below):
    • we need a gh-pages branch
    • we need to make sure under settings > Code and Automation > Pages > Build and Deployment that it's set to:
      • Source is set to Deploy from Branch
      • Branch is set to gh-pages and directory next to it is set to root (/)
        screenshot of the settings tab of a repo with Pages under Code and Automation selected on the left hand menu. It shows Deploy from Branch selected from a drop down menu under Build and deployment. The branch is set to gh-pages and the directory is set to root /

There's also a chance it has to do with the directory the helm chart is in. It's normally expected that the helm chart is in charts/appname so in this case it'd be charts/seaweedfs-operator, but I don't think that's it though, because I set the chart dir in the workflow according to the docs 🤔

with:
charts_dir: deploy/helm

@jessebot
Copy link
Contributor Author

@chrislusf could you please create the gh-pages branch, when you have a chance? I think this is why the helm chart release did not work. Thank you for all your help 🙏

@chrislusf
Copy link
Collaborator

Created https://github.com/seaweedfs/seaweedfs-operator/tree/gh-pages

Let me know if anything is needed.

@xavier83
Copy link
Contributor

xavier83 commented Oct 14, 2024

can't we take inspiration from seaweedfs for this?

Created PR #115 for testing this.

@xavier83
Copy link
Contributor

@chrislusf #116 seems to publish the charts now.

The following works.

helm repo add seaweedfs-operator https://seaweedfs.github.io/seaweedfs-operator/helm
helm template  seaweedfs-operator seaweedfs-operator/seaweedfs-operator

we may have to clean-up gh-pages branch similar to https://github.com/seaweedfs/seaweedfs/tree/gh-pages/ https://#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants