Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromBSONByteArray: aByteArray in: aMaplessRepository #157

Open
sebastianconcept opened this issue Feb 17, 2024 · 1 comment
Open

fromBSONByteArray: aByteArray in: aMaplessRepository #157

sebastianconcept opened this issue Feb 17, 2024 · 1 comment
Labels
chore A maintenance or marginal improvement task

Comments

@sebastianconcept
Copy link
Owner

That method belongs to the Mongo package

@sebastianconcept sebastianconcept added the chore A maintenance or marginal improvement task label Feb 17, 2024
@sebastianconcept
Copy link
Owner Author

The thing is that, in MaplessRedisRepository we have this:

save: aMapless
	| key storable serialized |
	self onBeforeSave: aMapless.
	key := self namespacedIdOf: aMapless.
	storable := resolver storableFor: aMapless in: self.
	serialized := BSON write: storable.
	accessor redis at: key put: serialized.
	self onAfterSave: aMapless

And instead of serialized := BSON write: storable. we should have something like serialized := self serialize: storable so we could potentially have different serializing options in serialize: aStorable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A maintenance or marginal improvement task
Projects
None yet
Development

No branches or pull requests

1 participant