Trust: return meaningful status codes and hide internal DB errors (#24)

* Trust: return meaningful status codes and hide internal DB errors

* sourcery review updates

Author: fghanmi

internal/api/handlers.go

@@ -105,53 +105,53 @@ func (h *Handler) GetApiV1ArtifactsArtifactPolicies(w http.ResponseWriter, r *ht
 
 func (h *Handler) GetApiV1TrustConfig(w http.ResponseWriter, r *http.Request) {
 	tufRepoUrl := os.Getenv("TUF_REPO_URL")
-	resp, err := h.trustService.GetTrustConfig(r.Context(), tufRepoUrl)
+	resp, err, statusCode := h.trustService.GetTrustConfig(r.Context(), tufRepoUrl)
 	if err != nil {
-		writeError(w, http.StatusInternalServerError, err.Error())
+		writeError(w, statusCode, err.Error())
 		return
 	}
-	writeJSON(w, http.StatusOK, resp)
+	writeJSON(w, statusCode, resp)
 }
 
 func (h *Handler) GetApiV1TrustRootMetadata(w http.ResponseWriter, r *http.Request) {
 	tufRepoUrl := os.Getenv("TUF_REPO_URL")
-	resp, err := h.trustService.GetTrustRootMetadataInfo(tufRepoUrl)
+	resp, err, statusCode := h.trustService.GetTrustRootMetadataInfo(tufRepoUrl)
 	if err != nil {
-		writeError(w, http.StatusInternalServerError, err.Error())
+		writeError(w, statusCode, err.Error())
 		return
 	}
-	writeJSON(w, http.StatusOK, resp)
+	writeJSON(w, statusCode, resp)
 }
 
 func (h *Handler) GetApiV1TrustTargets(w http.ResponseWriter, r *http.Request) {
 	tufRepoUrl := os.Getenv("TUF_REPO_URL")
-	resp, err := h.trustService.GetAllTargets(r.Context(), tufRepoUrl)
+	resp, err, statusCode := h.trustService.GetAllTargets(r.Context(), tufRepoUrl)
 	if err != nil {
-		writeError(w, http.StatusInternalServerError, err.Error())
+		writeError(w, statusCode, err.Error())
 		return
 	}
-	writeJSON(w, http.StatusOK, resp)
+	writeJSON(w, statusCode, resp)
 }
 
 func (h *Handler) GetApiV1TrustTarget(w http.ResponseWriter, r *http.Request) {
 	tufRepoUrl := os.Getenv("TUF_REPO_URL")
 	target := r.URL.Query().Get("target")
-	resp, err := h.trustService.GetTarget(r.Context(), tufRepoUrl, target)
+	resp, err, statusCode := h.trustService.GetTarget(r.Context(), tufRepoUrl, target)
 	if err != nil {
-		writeError(w, http.StatusInternalServerError, err.Error())
+		writeError(w, statusCode, err.Error())
 		return
 	}
-	writeJSON(w, http.StatusOK, resp)
+	writeJSON(w, statusCode, resp)
 }
 
 func (h *Handler) GetApiV1TrustTargetsCertificates(w http.ResponseWriter, r *http.Request) {
 	tufRepoUrl := os.Getenv("TUF_REPO_URL")
-	resp, err := h.trustService.GetCertificatesInfo(r.Context(), tufRepoUrl)
+	resp, err, statusCode := h.trustService.GetCertificatesInfo(r.Context(), tufRepoUrl)
 	if err != nil {
-		writeError(w, http.StatusInternalServerError, err.Error())
+		writeError(w, statusCode, err.Error())
 		return
 	}
-	writeJSON(w, http.StatusOK, resp)
+	writeJSON(w, statusCode, resp)
 }
 
 func (h *Handler) ServeSwaggerUI(w http.ResponseWriter, r *http.Request) {