Skip to content

[importer] disable requirement for entity names to be unique #826

Open
@tlongers

Description

@tlongers

In some cases, there are different values in person:id:admin for the same string in person:name string:

person:id:admin person:name
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Moe Aung
404df6f2-c490-4605-8e8b-7ddb8ec75f7e Moe Aung

The sfm-cms importer is conservative, and flags these as a possible data entry error:

"Got multiple UUID values for person name"

However, the data are correct: there are two distinct people with the same name. I think it may be a legacy of the period before we used uuids as identifiers but used names instead.

I think this is where it is called:

self.log_conflicts(entity_type, entity_map, transpose=True)

So this particular check should be disabled in the importer.

For completion, the check that sholud be retained retain is the reverse of the above - those cases where there is variation in the string in person:name, but the uuid in person:id:admin remains the same:

person:id:admin person:name
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Moe Aung
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Davy Jones

This indicates an error that we want to know about.

@tonysecurityforcemonitor double check my reasoning here please.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions