Skip to content

Commit ae3a339

Browse files
AaronMoat72636c
andauthored
Stop ignoring cdk.context.json (#1851)
Co-authored-by: Ryan Ling <[email protected]>
1 parent 695605d commit ae3a339

File tree

9 files changed

+15
-9
lines changed

9 files changed

+15
-9
lines changed

Diff for: .changeset/cuddly-sides-grab.md

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'skuba': minor
3+
---
4+
5+
format, lint: Remove `cdk.context.json` from managed `.gitignore`
6+
7+
AWS CDK generates a `cdk.context.json` file when running commands like `cdk synth` or `cdk deploy`. This file is [recommended to be included in source control](https://docs.aws.amazon.com/cdk/v2/guide/context.html#context_construct).
8+
9+
If this change is incompatible with your project's setup, manually add `cdk.context.json` back to your `.gitignore` file, outside of the **skuba**-managed section.

Diff for: .gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
.cdk.staging/
77
.serverless/
88
cdk.out/
9-
cdk.context.json
109
node_modules*/
1110

1211
/coverage*/

Diff for: package.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,11 @@
3131
"build": "scripts/build.sh",
3232
"changeset": "changeset",
3333
"deploy": "scripts/deploy.sh",
34-
"format": "pnpm --silent skuba format",
35-
"lint": "pnpm --silent skuba lint && pnpm --silent lint:md",
34+
"format": "pnpm --silent skuba format && pnpm format:packages",
35+
"format:packages": "pnpm --filter '!./template/**' format",
36+
"lint": "pnpm --silent skuba lint && pnpm lint:packages && pnpm --silent lint:md",
3637
"lint:md": "remark --frail --quiet .",
38+
"lint:packages": "pnpm --filter '!./template/**' lint",
3739
"prepack": "pnpm --filter './template/**' exec rm -rf node_modules",
3840
"release": "pnpm --silent build && changeset publish",
3941
"skuba": "pnpm --silent build && pnpm --silent skuba:exec",

Diff for: packages/eslint-config-skuba/.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
.cdk.staging/
77
.serverless/
88
cdk.out/
9-
cdk.context.json
109
node_modules*/
1110

1211
/coverage*/

Diff for: packages/eslint-config-skuba/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,6 @@
4949
"entryPoint": "index.js",
5050
"template": "oss-npm-package",
5151
"type": "package",
52-
"version": "10.0.1"
52+
"version": "10.1.0"
5353
}
5454
}

Diff for: packages/skuba-dive/.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
.cdk.staging/
77
.serverless/
88
cdk.out/
9-
cdk.context.json
109
node_modules*/
1110

1211
/coverage*/

Diff for: packages/skuba-dive/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@
4444
"entryPoint": "src/index.ts",
4545
"template": "oss-npm-package",
4646
"type": "package",
47-
"version": "8.2.1"
47+
"version": "10.1.0"
4848
}
4949
}

Diff for: src/cli/configure/analysis/__snapshots__/project.test.ts.snap

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ yarn-error.log
3939
.cdk.staging/
4040
.serverless/
4141
cdk.out/
42-
cdk.context.json
4342
node_modules*/
4443
4544
/coverage*/

Diff for: template/base/_.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
.cdk.staging/
77
.serverless/
88
cdk.out/
9-
cdk.context.json
109
node_modules*/
1110

1211
/coverage*/

0 commit comments

Comments
 (0)