STRATCONN-6300 - [Mixpanel Web] - more bugfixes (#3512)

* STRATCONN-6300 - [Mixpanel Web] - more bugfixes

* types

* removing default mappings for track and page

Author: joe-ayoub-segment

packages/browser-destinations/destinations/mixpanel-web/src/index.ts

@@ -42,6 +42,31 @@ export const destination: BrowserDestinationDefinition<Settings, Mixpanel> = {
       ...rest
     } = settings
 
+    const numericKeys = new Set([
+      'record_sessions_percent',
+      'record_min_ms',
+      'record_max_ms',
+      'record_idle_timeout_ms',
+      'cookie_expiration'
+    ])
+    
+    const remainingSettings = Object.fromEntries(
+      Object.entries(rest).flatMap(([key, value]) => {
+        if (numericKeys.has(key)) {
+          if (value === undefined || value === null || value === '') { 
+            return [] 
+          }
+          const num = Number(value)
+          if (Number.isNaN(num)) {
+            console.warn(`Setting "${key}" with value "${value}" cannot be converted to a number. Setting will be ignored.`)
+            return []
+          }
+          return [[key, num]]
+        }
+        return [[key, value]]
+      })
+    )
+    
     const config: Config = {
       autocapture:
         autocapture === AUTOCAPTURE_OPTIONS.CUSTOM
@@ -59,7 +84,7 @@ export const destination: BrowserDestinationDefinition<Settings, Mixpanel> = {
           ? true
           : false,
       persistence: persistence as PersistenceOptions,
-      ...rest
+      ...remainingSettings
     }
 
     return new Promise<Mixpanel>((resolve) => {

packages/browser-destinations/destinations/mixpanel-web/src/track/index.ts

@@ -31,57 +31,7 @@ const action: BrowserActionDefinition<Settings, Mixpanel, Payload> = {
     },
     user_profile_properties_to_set: {
       ...user_profile_properties_to_set,
-      default: { 
-        name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.name' },
-            then: { '@path': '$.context.traits.name' },
-            else: { '@path': '$.properties.name' }
-          }
-        },
-        first_name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.first_name' },
-            then: { '@path': '$.context.traits.first_name' },
-            else: { '@path': '$.properties.first_name' }
-          }
-        },
-        last_name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.last_name' },
-            then: { '@path': '$.context.traits.last_name' },
-            else: { '@path': '$.properties.last_name' }
-          }
-        },
-        email: {
-          '@if': {
-            exists: { '@path': '$.context.traits.email' },
-            then: { '@path': '$.context.traits.email' },
-            else: { '@path': '$.properties.email' }
-          }
-        },  
-        phone: {
-          '@if': {
-            exists: { '@path': '$.context.traits.phone' },
-            then: { '@path': '$.context.traits.phone' },
-            else: { '@path': '$.properties.phone' }
-          }
-        },
-        avatar: {
-          '@if': {
-            exists: { '@path': '$.context.traits.avatar' },
-            then: { '@path': '$.context.traits.avatar' },
-            else: { '@path': '$.properties.avatar' }
-          }
-        },
-        created: {
-          '@if': {
-            exists: { '@path': '$.context.traits.created_at' },
-            then: { '@path': '$.context.traits.created_at' },
-            else: { '@path': '$.properties.created_at' }
-          }
-        }
-      }
+      default: undefined
     },
     user_profile_properties_to_set_once,
     user_profile_properties_to_increment,

packages/browser-destinations/destinations/mixpanel-web/src/trackPageView/generated-types.ts

@@ -24,68 +24,21 @@ const action: BrowserActionDefinition<Settings, Mixpanel, Payload> = {
   fields: {
     event_name: {
       ...event_name,
-      default: undefined,
+      default: {
+        '@path': '$.name'
+      },
       required: false
     },
     properties,
     unique_id: {
       ...unique_id,
       description: 'The unique ID to associate with the user. Settings this value will trigger a Mixpanel identify call before immediately the page event is sent.',
-      default: undefined
+      default: undefined, 
+      required: false
     },
     user_profile_properties_to_set: {
       ...user_profile_properties_to_set,
-      default: { 
-        name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.name' },
-            then: { '@path': '$.context.traits.name' },
-            else: { '@path': '$.properties.name' }
-          }
-        },
-        first_name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.first_name' },
-            then: { '@path': '$.context.traits.first_name' },
-            else: { '@path': '$.properties.first_name' }
-          }
-        },
-        last_name: {
-          '@if': {
-            exists: { '@path': '$.context.traits.last_name' },
-            then: { '@path': '$.context.traits.last_name' },
-            else: { '@path': '$.properties.last_name' }
-          }
-        },
-        email: {
-          '@if': {
-            exists: { '@path': '$.context.traits.email' },
-            then: { '@path': '$.context.traits.email' },
-            else: { '@path': '$.properties.email' }
-          }
-        },  
-        phone: {
-          '@if': {
-            exists: { '@path': '$.context.traits.phone' },
-            then: { '@path': '$.context.traits.phone' },
-            else: { '@path': '$.properties.phone' }
-          }
-        },
-        avatar: {
-          '@if': {
-            exists: { '@path': '$.context.traits.avatar' },
-            then: { '@path': '$.context.traits.avatar' },
-            else: { '@path': '$.properties.avatar' }
-          }
-        },
-        created: {
-          '@if': {
-            exists: { '@path': '$.context.traits.created_at' },
-            then: { '@path': '$.context.traits.created_at' },
-            else: { '@path': '$.properties.created_at' }
-          }
-        }
-      }
+      default: undefined
     },
     user_profile_properties_to_set_once,
     user_profile_properties_to_increment,