Add a benchmark which uses Google benchmark library #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seladb
reviewed
Oct 15, 2024
egecetin
commented
Nov 11, 2024
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.12) | |||
| cmake_minimum_required(VERSION 3.14) | |||
There was a problem hiding this comment.
fetchcontent_makeavailable added in 3.14
|
@seladb It is ready to review if you have time |
seladb
approved these changes
Nov 13, 2024
| // Parse command line arguments to find the pcap file name | ||
| for (int idx = 1; idx < argc; ++idx) | ||
| { | ||
| if (strcmp(argv[idx], "--pcap-file") == 0) |
There was a problem hiding this comment.
Since --pcap-file is a mandatory parameter (and the only param for now), maybe we don't need the param itself and can run the benchmark like this:
.\BenchmarkExampleGoogle.exe D:\my_packets.pcap
There was a problem hiding this comment.
@seladb The problem is arguments are also used by google benchmark. It supports some flags as default, for example --benchmark_filter or --benchmark_out_format etc. So --pcap-file actually not only parameter.
tigercosmos
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generate performance benchmark information for website using Google BenchmarkAdd a google benchmark based benchmark application