Skip to content

Commit 61634f3

Browse files
author
Vitaliy Saveliev
committed
Fix semgrep warnings
1 parent 7696fa6 commit 61634f3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

selvpcclient/util.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ def make_curl(url, method, data):
211211
v = str()
212212
if value:
213213
v = value.encode('utf-8')
214-
h = hashlib.sha1(v)
214+
h = hashlib.sha256(v)
215215
d = h.hexdigest()
216216
value = "{SHA1}%s" % d
217217
header = ' -H "%s: %s"' % (key, value)
@@ -225,15 +225,17 @@ def make_curl(url, method, data):
225225
def is_url(data):
226226
"""Checks if getting value is valid url and path exists."""
227227
try:
228-
r = requests.head(data)
229-
except Exception:
228+
r = requests.head(data, timeout=15)
229+
r.raise_for_status()
230+
except requests.RequestException:
230231
return False
231232
return r.status_code == requests.codes.ok
232233

233234

234235
def process_logo_by_url(url):
235236
"""Download and encode image by url."""
236-
res = requests.get(url)
237+
res = requests.get(url, timeout=15)
238+
res.raise_for_status()
237239
encoded_logo = base64.b64encode(res.content)
238240
return encoded_logo
239241

0 commit comments

Comments
 (0)