Skip to content

Commit 4f125e4

Browse files
committed
Deprecate scroll_click() - All clicks now scroll first
1 parent 117c8b6 commit 4f125e4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

help_docs/method_summary.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ self.scroll_to(selector, by=By.CSS_SELECTOR)
7575

7676
self.slow_scroll_to(selector, by=By.CSS_SELECTOR)
7777

78-
self.scroll_click(selector, by=By.CSS_SELECTOR)
78+
self.scroll_click(selector, by=By.CSS_SELECTOR) # DEPRECATED
7979

8080
self.click_xpath(xpath)
8181

seleniumbase/fixtures/base_case.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,8 @@ def slow_scroll_to(self, selector, by=By.CSS_SELECTOR,
624624
self._slow_scroll_to_element(element)
625625

626626
def scroll_click(self, selector, by=By.CSS_SELECTOR):
627-
self.scroll_to(selector, by=by)
627+
# DEPRECATED - self.click() now scrolls to the element before clicking
628+
# self.scroll_to(selector, by=by)
628629
self.click(selector, by=by)
629630

630631
def click_xpath(self, xpath):

0 commit comments

Comments
 (0)