Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate rules for Slack webhook URL #3345

Open
Sjord opened this issue Mar 28, 2024 · 2 comments
Open

Duplicate rules for Slack webhook URL #3345

Sjord opened this issue Mar 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Sjord
Copy link
Contributor

Sjord commented Mar 28, 2024

There are two rules that warn about the same thing:

@Sjord Sjord added the bug Something isn't working label Mar 28, 2024
@Sjord
Copy link
Contributor Author

Sjord commented Mar 28, 2024

@LewisArdern
Copy link
Contributor

LewisArdern commented Mar 28, 2024

A lot of people were asking for gitleaks, its an automated process and it gets updated if gitleaks changes their regex

Most people use Semgrep CI and gitleaks is not included in the default experience which means duplicate findings wouldn't occur for them.

For now we won't deduplicate, but will consider it in the future and can understand it may cause some frustration on those using direct clones of semgrep-rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants