Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN breaks UI #5

Open
ibevers opened this issue Jan 10, 2025 · 4 comments
Open

NaN breaks UI #5

ibevers opened this issue Jan 10, 2025 · 4 comments

Comments

@ibevers
Copy link

ibevers commented Jan 10, 2025

Items that have NaN in them don't work in reproschema-ui. For example, in activities/q_generic_demographics/items/state_province, as of 3.20.0 we have:

    "additionalNotesObj": [
        {
            "column": "Question Number (surveys only)",
            "source": "redcap",
            "value": NaN
        }
    ]

Can we put this in quotes (i.e. "NaN") @Evan8456 @yibeichan?

@Evan8456
Copy link
Contributor

Evan8456 commented Jan 10, 2025

This would probably need to be changed in the redcap2reproschema code. Most likely somewhere here : @yibeichan what do you think?

@yibeichan
Copy link
Collaborator

hi hi sorry guys, how about this PR ReproNim/reproschema-py#81

@yibeichan
Copy link
Collaborator

@ibevers hi hi, satra asked about whether we want to keep nan or drop them here ReproNim/reproschema-py#81 (comment)

@ibevers
Copy link
Author

ibevers commented Jan 15, 2025

@yibeichan I don't have enough background context to say. I don't have a strong opinion as long as it doesn't break when run in the UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants