InsertUpdateLogBehavior Dates

[edwardch]

Hi team Serenity!

I have a database that's using DateTime.UtcNow as a default for InsertDate.

Migration is something like this:

.WithColumn("InsertUserId").AsInt32().Nullable()
.WithColumn("InsertDate").AsDateTime().NotNullable().WithDefault(SystemMethods.CurrentUTCDateTime)
.WithColumn("UpdateDate").AsDateTime().Nullable()
.WithColumn("UpdateUserId").AsInt32().Nullable();

This InsertDate has a constraint:

ALTER TABLE [dbo].[Customers] ADD  CONSTRAINT [DF_Customers_InsertDate]  DEFAULT (getutcdate())

I noticed that the dates in the update column are using DateTime.Now, so my InsertDate vs UpdateDate in my table doesn't make much sense.

Serenity/src/services/RequestHandlers/IntegratedFeatures/InsertUpdateLog/InsertUpdateLogBehavior.cs

Line 26 in b26ba30

updateDateRow.UpdateDateField[row] = DateTimeField.ToDateTimeKind(DateTime.Now,

Should we be using UtcNow rather?

I understand that this may affect existing applications, so perhaps an option to .Now instead of .UtcNow?

What are your thoughts?

Cheers!
Edward

[VictorTomaili]

It uses ToDateTimeKind function to convert date to "utc or local" which uses date time kind attribute on field.

[edwardch]

Ahh, I see! My apologies...

I was using Serenity.Extensions.Entities.LoggingRow directly, which doesn't have a DateTimeKind specified.

For others that are looking at this in future, create a copy of Serenity.Extensions.Entities.LoggingRow, and update the date attributes.

    [NotNull, Insertable(false), Updatable(false)]
    [DateTimeKind(DateTimeKind.Utc)] // Use this attribute to update your DateTimeKind
    public DateTime? InsertDate { get => fields.InsertDate[this]; set => fields.InsertDate[this] = value; }

    [Insertable(false), Updatable(false)]
    public int? UpdateUserId { get => fields.UpdateUserId[this]; set => fields.UpdateUserId[this] = value; }

    [Insertable(false), Updatable(false)]
    [DateTimeKind(DateTimeKind.Utc)] // Use this attribute to update your DateTimeKind
    public DateTime? UpdateDate { get => fields.UpdateDate[this]; set => fields.UpdateDate[this] = value; }

Then you can reference it in your *Row.cs like this:

public sealed partial class CustomerRow : YourAwesomeProject.Extensions.Entities.LoggingRow<CustomerRow.RowFields>, IIdRow, INameRow

Thanks Victor!