Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll results added to the API #2948

Open
vicky5124 opened this issue Aug 17, 2024 · 1 comment
Open

Poll results added to the API #2948

vicky5124 opened this issue Aug 17, 2024 · 1 comment

Comments

@vicky5124
Copy link
Contributor

A new poll result message has been added. This includes a new message type with the ID 46 called POLL_RESULT, as well as a new embed type with the field name poll_result, and a new type to accompany it.

Note that the types of the fields in the new type have not been documented, the documentation only shows if they are optional fields or not, as well as their description. A review of the pull request notes that all the values are strings, but this has not been validated, and for ergonomics, it may be best to parse the values to their appropriate type, which is something the review also mentioned.

Discord API docs change commit (Poll) | PR

There's also a new deletable message type with the ID 44 called PURCHASE_NOTIFICATION that was missed, that could be easily added along with this change.

Discord API docs change commit (Purchase)

@ivinjabraham
Copy link
Contributor

Working on this right now. From what I understand, the fields in an Embed are optional and we provide support for them as documented. This appears to be the first time we've been given the possible fields for the new poll_result embed type. With the current implementation of EmbedField, these new fields should be covered as well right? Or is there something I'm missing and we can add in the new information provided?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants