fix(Dashboard): Function create vs update

- An `IsNew` variable was added to the state, which tracks whether the function is new or existing. This change prevents unnecessary API calls, reducing 404 errors and improving efficiency.

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>

Author: JBBianchi

src/dashboard/Synapse.Dashboard/Pages/Functions/Create/State.cs

@@ -18,7 +18,7 @@
 namespace Synapse.Dashboard.Pages.Functions.Create;
 
 /// <summary>
-/// The <see cref="State{TState}"/> of the workflow editor
+/// The <see cref="State{TState}"/> of the function editor
 /// </summary>
 [Feature]
 public record CreateFunctionViewState
@@ -40,7 +40,12 @@ public record CreateFunctionViewState
     public SemVersion Version { get; set; } = new SemVersion(1, 0, 0);
 
     /// <summary>
-    /// Gets/sets the definition of the workflow to create
+    /// Gets/sets a boolean determining if the function is new or if it's an update
+    /// </summary>
+    public bool IsNew { get; set; } = true;
+
+    /// <summary>
+    /// Gets/sets the definition of the function to create
     /// </summary>
     public TaskDefinition? Function { get; set; } = null;
 

src/dashboard/Synapse.Dashboard/Pages/Functions/Create/Store.cs

@@ -16,6 +16,7 @@
 using Semver;
 using ServerlessWorkflow.Sdk.Models;
 using Synapse.Api.Client.Services;
+using Synapse.Dashboard.Pages.Workflows.Create;
 using Synapse.Resources;
 
 namespace Synapse.Dashboard.Pages.Functions.Create;
@@ -189,7 +190,6 @@ MonacoInterop monacoInterop
     #endregion
 
     #region Setters
-
     /// <summary>
     /// Sets the state's <see cref="CreateFunctionViewState.Name"/>
     /// </summary>
@@ -215,6 +215,18 @@ public void SetChosenName(string? name)
         });
     }
 
+    /// <summary>
+    /// Sets the state's <see cref="CreateFunctionViewState.IsNew"/>
+    /// </summary>
+    /// <param name="isNew">The new <see cref="CreateFunctionViewState.IsNew"/> value</param>
+    public void SetIsNew(bool isNew)
+    {
+        this.Reduce(state => state with
+        {
+            IsNew = isNew
+        });
+    }
+
     /// <summary>
     /// Sets the state's <see cref="CreateFunctionViewState" /> <see cref="ProblemDetails"/>'s related data
     /// </summary>
@@ -393,6 +405,7 @@ public async Task SaveCustomFunctionAsync()
                 this.YamlSerializer.Deserialize<TaskDefinition>(functionText)!;
             var name = this.Get(state => state.Name) ?? this.Get(state => state.ChosenName);
             var version = this.Get(state => state.Version).ToString();
+            var isNew = this.Get(state => state.IsNew);
             if (string.IsNullOrEmpty(name))
             {
                 this.Reduce(state => state with
@@ -407,41 +420,41 @@ public async Task SaveCustomFunctionAsync()
                 Saving = true
             });
             CustomFunction? resource = null;
-            try
-            {
-                resource = await this.ApiClient.CustomFunctions.GetAsync(name);
-            }
-            catch
+            if (isNew)
             {
-                // Assume 404, might need actual handling
-            }
-            if (resource == null)
-            {
-                resource = await this.ApiClient.CustomFunctions.CreateAsync(new()
+
+                try
                 {
-                    Metadata = new()
+                    resource = await this.ApiClient.CustomFunctions.CreateAsync(new()
                     {
-                        Name = name
-                    },
-                    Spec = new()
-                    {
-                        Versions = [new(version, function)]
-                    }
-                });
-            }
-            else
-            {
-                var updatedResource = resource.Clone()!;
-                updatedResource.Spec.Versions.Add(new(version, function));
-                var jsonPatch = JsonPatch.FromDiff(this.JsonSerializer.SerializeToElement(resource)!.Value, this.JsonSerializer.SerializeToElement(updatedResource)!.Value);
-                var patch = this.JsonSerializer.Deserialize<Json.Patch.JsonPatch>(jsonPatch.RootElement);
-                if (patch != null)
+                        Metadata = new()
+                        {
+                            Name = name
+                        },
+                        Spec = new()
+                        {
+                            Versions = [new(version, function)]
+                        }
+                    });
+                    this.NavigationManager.NavigateTo($"/functions/{name}");
+                    return;
+                }
+                catch (ProblemDetailsException ex) when (ex.Problem.Title == "Conflict" && ex.Problem.Detail != null && ex.Problem.Detail.EndsWith("already exists"))
                 {
-                    var resourcePatch = new Patch(PatchType.JsonPatch, jsonPatch);
-                    await this.ApiClient.ManageCluster<CustomFunction>().PatchAsync(name, resourcePatch, null, this.CancellationTokenSource.Token);
+                    // the function exists, try to update it instead
                 }
             }
-            this.NavigationManager.NavigateTo($"/functions/{name}");
+            resource = await this.ApiClient.CustomFunctions.GetAsync(name);
+            var updatedResource = resource.Clone()!;
+            updatedResource.Spec.Versions.Add(new(version, function));
+            var jsonPatch = JsonPatch.FromDiff(this.JsonSerializer.SerializeToElement(resource)!.Value, this.JsonSerializer.SerializeToElement(updatedResource)!.Value);
+            var patch = this.JsonSerializer.Deserialize<Json.Patch.JsonPatch>(jsonPatch.RootElement);
+            if (patch != null)
+            {
+                var resourcePatch = new Patch(PatchType.JsonPatch, jsonPatch);
+                await this.ApiClient.ManageCluster<CustomFunction>().PatchAsync(name, resourcePatch, null, this.CancellationTokenSource.Token);
+            }
+            
         }
         catch (ProblemDetailsException ex)
         {
@@ -477,6 +490,15 @@ public async Task SaveCustomFunctionAsync()
         catch (Exception ex)
         {
             this.Logger.LogError("Unable to save function definition: {exception}", ex.ToString());
+            this.Reduce(state => state with
+            {
+                ProblemTitle = "Error",
+                ProblemDetail = "An error occurred while saving the function.",
+                ProblemErrors = new Dictionary<string, string[]>()
+                {
+                    {"Message", [ex.ToString()] }
+                }
+            });
         }
         finally
         {

src/dashboard/Synapse.Dashboard/Pages/Functions/Create/View.razor

@@ -47,10 +47,10 @@ else
         <PreferredLanguageSelector PreferredLanguageChange="Store.ToggleTextBasedEditorLanguageAsync" />
     </div>
     <StandaloneCodeEditor @ref="Store.TextEditor"
-                          ConstructionOptions="Store.StandaloneEditorConstructionOptions"
-                          OnDidInit="Store.OnTextBasedEditorInitAsync"
-                          OnDidChangeModelContent="Store.OnDidChangeModelContent"
-                          CssClass="h-100" />
+    ConstructionOptions="Store.StandaloneEditorConstructionOptions"
+    OnDidInit="Store.OnTextBasedEditorInitAsync"
+    OnDidChangeModelContent="Store.OnDidChangeModelContent"
+    CssClass="h-100" />
     @if (problemDetails != null)
     {
         <div class="problems px-3">
@@ -104,6 +104,7 @@ else
         await base.OnInitializedAsync();
         BreadcrumbManager.Use(Breadcrumbs.Functions);
         BreadcrumbManager.Add(new("New", "/functions/new"));
+        Store.SetIsNew(true);
         Store.Name.Subscribe(value => OnStateChanged(_ => name = value), token: CancellationTokenSource.Token);
         Store.ChosenName.Subscribe(value => OnStateChanged(_ => chosenName = value), token: CancellationTokenSource.Token);
         Store.Version.Subscribe(value => OnStateChanged(_ => version = value?.ToString()), token: CancellationTokenSource.Token);
@@ -115,7 +116,11 @@ else
     /// <inheritdoc/>
     protected override void OnParametersSet()
     {
-        if (Name != name) Store.SetName(Name);
+        if (Name != name)
+        {
+            Store.SetName(Name);
+            Store.SetIsNew(false);
+        }
     }
 
     protected void SetName()

src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs

@@ -19,7 +19,6 @@
 using Synapse.Api.Client.Services;
 using Synapse.Resources;
 using System.Text.RegularExpressions;
-using System.Xml.Linq;
 
 namespace Synapse.Dashboard.Pages.Workflows.Create;
 
@@ -513,6 +512,15 @@ public async Task SaveWorkflowDefinitionAsync()
         catch (Exception ex)
         {
             this.Logger.LogError("Unable to save workflow definition: {exception}", ex.ToString());
+            this.Reduce(state => state with
+            {
+                ProblemTitle = "Error",
+                ProblemDetail = "An error occurred while saving the workflow.",
+                ProblemErrors = new Dictionary<string, string[]>()
+                {
+                    {"Message", [ex.ToString()] }
+                }
+            });
         }
         finally
         {