From 153996cc1508eba854d89fdbdedecc36db82edca Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Thu, 17 Aug 2023 15:16:33 +0200 Subject: [PATCH] Properly mark failed CI as failing There was a syntax error in `if` condition for the `Result` CI job. This meant that when a dependent job failed, the CI pipeline did not. This should fix branch protection for the merge queue. --- .github/workflows/rust.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 16cd7354533..6063a6dba0c 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -133,12 +133,12 @@ jobs: build_result: name: Result runs-on: ubuntu-latest - # Integrity check is broken for the time being; don't require it. needs: ["mac", "linux", "windows"] + if: ${{ always() }} steps: - name: Mark the job as successful run: exit 0 - if: success() + if: ${{ success() }} - name: Mark the job as unsuccessful run: exit 1 - if: "!success()" + if: ${{ !success() }}