-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Request ReplyUPtr expose at Redis++ Async response #554
Comments
Hi, Dear code officers Due to this request block my current project, so, I did simple changes to expose hiredis redisReply. For sure, we will keep the mindset, redisReply after CB, it will be freed by hiredis. THanks. |
Thanks for your PR! However, it's not a good idea to parse the reply to Why not use the generic interface to do the parse work? It works well with most cases, including Lua scripting. If you compile the code with C++17, with the power of Regards |
Most of traffic in my use case is redisModule, and user already with business logic to decode redisReply in current system. Since my PR had been draft ready, is it possible to gain your approval to provide an option to Redis-Plus-Plus user at least?? |
Instead of exposing redisReply to user, I was planing to expose a ReplyParser interface. So that user can parse redisReply to a user defined data structure. That might solve your problem. However, I'm too busy to start the project. Regards |
Is your feature request related to a problem? Please describe.
My use case prefer send all kinds of raw command, such as lua etc, and prefer to parse hiredis redisReply by application itself.
Describe the solution you'd like
Make ReplyUPtr = std::unique_ptr<redisReply, ReplyDeleter> possible to access as Async cluster client as Sync client did now.
Then, application can parse redisReply per itself.
Describe alternatives you've considered
N/A
Additional context
I prefer to know if that is feasible, and if doable, the draft schedule. Thanks.
The text was updated successfully, but these errors were encountered: