Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App should handle Login form validation in a more React-friendly way #320

Open
francisli opened this issue Oct 5, 2023 · 1 comment
Open

App should handle Login form validation in a more React-friendly way #320

francisli opened this issue Oct 5, 2023 · 1 comment

Comments

@francisli
Copy link
Collaborator

The migration of the Login/Forgot Password/2FA/Reset Password flows into the SPA resulted in some old JavaScript DOM related code being reused- particularly, in client/src/Auth/Components/helperFunctions.js.

These helper functions are being used to perform field validation, manipulating the DOM directly.

I think this should all be refactored into a more React-friendly implementation.
@fwextensions
Copy link
Collaborator

I haven't investigated this code, but it might be possible to use the native HTML input validation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fwextensions @francisli