[chore] Re-write the internal.State in pdata to support multiple properties. (open-telemetry#13633)

Part of
open-telemetry#13631

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

internal/cmd/pdatagen/internal/one_of_message_value.go

@@ -41,8 +41,9 @@ const oneOfMessageAccessorsTestTemplate = `func Test{{ .structName }}_{{ .fieldN
 	internal.FillOrigTest{{ .returnType }}(ms.orig.Get{{ .originOneOfFieldName }}().(*{{ .originStructType }}).{{ .fieldName }})
 	assert.Equal(t, {{ .typeName }}, ms.{{ .originOneOfTypeFuncName }}())
 	assert.Equal(t, generateTest{{ .returnType }}(), ms.{{ .fieldName }}())
-	sharedState := internal.StateReadOnly
-	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, &sharedState).SetEmpty{{ .fieldName }}() })
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, sharedState).SetEmpty{{ .fieldName }}() })
 }
 `
 

internal/cmd/pdatagen/internal/one_of_primitive_value.go

@@ -39,8 +39,9 @@ const oneOfPrimitiveAccessorTestTemplate = `func Test{{ .structName }}_{{ .acces
 	assert.Equal(t, {{ .testValue }}, ms.{{ .accessorFieldName }}())
 	{{- end }}
 	assert.Equal(t, {{ .typeName }}, ms.{{ .originOneOfTypeFuncName }}())
-	sharedState := internal.StateReadOnly
-	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, &sharedState).Set{{ .accessorFieldName }}({{ .testValue }}) })
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, sharedState).Set{{ .accessorFieldName }}({{ .testValue }}) })
 }
 `
 

internal/cmd/pdatagen/internal/primitive_field.go

@@ -40,8 +40,9 @@ const primitiveAccessorsTestTemplate = `func Test{{ .structName }}_{{ .fieldName
 	{{- else }}
 	assert.Equal(t, {{ .testValue }}, ms.{{ .fieldName }}())
 	{{- end }}
-	sharedState := internal.StateReadOnly
-	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, &sharedState).Set{{ .fieldName }}({{ .testValue }}) })
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	assert.Panics(t, func() { new{{ .structName }}(&{{ .originStructName }}{}, sharedState).Set{{ .fieldName }}({{ .testValue }}) })
 }`
 
 const primitiveSetTestTemplate = `orig.{{ .originFieldName }} = {{ .testValue }}`

internal/cmd/pdatagen/internal/templates/message.go.tmpl

@@ -41,8 +41,7 @@ func new{{ .structName }}(orig *{{ .originFullName }}, state *internal.State) {{
 // This must be used only in testing code. Users should use "AppendEmpty" when part of a Slice,
 // OR directly access the member if this is embedded in another struct.
 func New{{ .structName }}() {{ .structName }} {
-	state := internal.StateMutable
-	return new{{ .structName }}(&{{ .originFullName }}{}, &state)
+	return new{{ .structName }}(&{{ .originFullName }}{}, internal.NewState())
 }
 
 // MoveTo moves all properties from the current struct overriding the destination and

internal/cmd/pdatagen/internal/templates/message_internal.go.tmpl

@@ -33,8 +33,7 @@ func New{{ .structName }}(orig *{{ .originFullName }}, state *State) {{ .structN
 func GenerateTest{{ .structName }}() {{ .structName }} {
 	orig := {{ .originFullName }}{}
 	FillOrigTest{{ .originName }}(&orig)
-	state := StateMutable
-	return New{{ .structName }}(&orig, &state)
+	return New{{ .structName }}(&orig, NewState())
 }
 
 {{ end }}

internal/cmd/pdatagen/internal/templates/message_test.go.tmpl

@@ -20,9 +20,10 @@ func Test{{ .structName }}_MoveTo(t *testing.T) {
 	assert.Equal(t, generateTest{{ .structName }}(), dest)
 	dest.MoveTo(dest)
 	assert.Equal(t, generateTest{{ .structName }}(), dest)
-	sharedState := internal.StateReadOnly
-	assert.Panics(t, func() { ms.MoveTo(new{{ .structName }}(&{{ .originFullName }}{}, &sharedState)) })
-	assert.Panics(t, func() { new{{ .structName }}(&{{ .originFullName }}{}, &sharedState).MoveTo(dest) })
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	assert.Panics(t, func() { ms.MoveTo(new{{ .structName }}(&{{ .originFullName }}{}, sharedState)) })
+	assert.Panics(t, func() { new{{ .structName }}(&{{ .originFullName }}{}, sharedState).MoveTo(dest) })
 }
 
 func Test{{ .structName }}_CopyTo(t *testing.T) {
@@ -33,8 +34,9 @@ func Test{{ .structName }}_CopyTo(t *testing.T) {
 	orig = generateTest{{ .structName }}()
 	orig.CopyTo(ms)
 	assert.Equal(t, orig, ms)
-	sharedState := internal.StateReadOnly
-	assert.Panics(t, func() { ms.CopyTo(new{{ .structName }}(&{{ .originFullName }}{}, &sharedState)) })
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	assert.Panics(t, func() { ms.CopyTo(new{{ .structName }}(&{{ .originFullName }}{}, sharedState)) })
 }
 
 {{ range .fields }}

internal/cmd/pdatagen/internal/templates/primitive_slice.go.tmpl

@@ -30,8 +30,7 @@ func (ms {{ .structName }}) getState() *internal.State {
 // New{{ .structName }} creates a new empty {{ .structName }}.
 func New{{ .structName }}() {{ .structName }} {
 	orig := []{{ .itemType }}(nil)
-	state := internal.StateMutable
-	return {{ .structName }}(internal.New{{ .structName }}(&orig, &state))
+	return {{ .structName }}(internal.New{{ .structName }}(&orig, internal.NewState()))
 }
 
 // AsRaw returns a copy of the []{{ .itemType }} slice.

internal/cmd/pdatagen/internal/templates/primitive_slice_internal.go.tmpl

@@ -31,8 +31,7 @@ func New{{ .structName }}(orig *[]{{ .itemType }}, state *State) {{ .structName
 
 func GenerateTest{{ .structName }}() {{ .structName }} {
 	orig := GenerateOrigTest{{ .elementOriginName }}Slice()
-	state := StateMutable
-	return New{{ .structName }}(&orig, &state)
+	return New{{ .structName }}(&orig, NewState())
 }
 
 func CopyOrig{{ .elementOriginName }}Slice(dst, src []{{ .itemType }}) []{{ .itemType }} {

internal/cmd/pdatagen/internal/templates/primitive_slice_test.go.tmpl

@@ -76,8 +76,9 @@ func TestNew{{ .structName }}(t *testing.T) {
 
 func Test{{ .structName }}ReadOnly(t *testing.T) {
 	raw := []{{ .itemType }}{ {{ .testOrigVal }}}
-	state := internal.StateReadOnly
-	ms := {{ .structName }}(internal.New{{ .structName }}(&raw, &state))
+	sharedState := internal.NewState()
+	sharedState.MarkReadOnly()
+	ms := {{ .structName }}(internal.New{{ .structName }}(&raw, sharedState))
 
 	assert.Equal(t, 3, ms.Len())
 	{{- if eq .itemType "float64" }}

internal/cmd/pdatagen/internal/templates/slice.go.tmpl

@@ -40,8 +40,7 @@ func new{{ .structName }}(orig *[]{{ .originElementType }}, state *internal.Stat
 // Can use "EnsureCapacity" to initialize with a given capacity.
 func New{{ .structName }}() {{ .structName }} {
 	orig := []{{ .originElementType }}(nil)
-	state := internal.StateMutable
-	return new{{ .structName }}(&orig, &state)
+	return new{{ .structName }}(&orig, internal.NewState())
 }
 
 // Len returns the number of elements in the slice.