Skip to content

Commit f9197ad

Browse files
authored
Deprecate SizeConfig as well from exporterhelper (open-telemetry#12749)
I forgot about this in the previous PR. Signed-off-by: Bogdan Drutu <[email protected]>
1 parent ced2880 commit f9197ad

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

.chloggen/deprecate-batcher-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ change_type: deprecation
77
component: exporterhelper
88

99
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10-
note: Deprecate BatcherConfig and WithBatcher in favor of the new QueueBatchConfig.
10+
note: Deprecate BatcherConfig, SizeConfig and WithBatcher in favor of the new QueueBatchConfig.
1111

1212
# One or more tracking issues or pull requests related to the change
1313
issues: [12748]

exporter/exporterbatcher/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
type Config = exporterhelper.BatcherConfig //nolint:staticcheck
1212

1313
// Deprecated: [v0.123.0] use exporterhelper.SizeConfig
14-
type SizeConfig = exporterhelper.SizeConfig
14+
type SizeConfig = exporterhelper.SizeConfig //nolint:staticcheck
1515

1616
// Deprecated: [v0.123.0] use exporterhelper.RequestSizerType
1717
type SizerType = exporterhelper.RequestSizerType

exporter/exporterhelper/queue_batch.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ var NewDefaultQueueConfig = internal.NewDefaultQueueConfig
6565
// Deprecated: [v0.123.0] use WithQueueBatch.
6666
type BatcherConfig = internal.BatcherConfig
6767

68-
// SizeConfig sets the size limits for a batch.
69-
// Experimental: This API is at the early stage of development and may change without backward compatibility
70-
// until https://github.com/open-telemetry/opentelemetry-collector/issues/8122 is resolved.
68+
// Deprecated: [v0.123.0] use WithQueueBatch.
7169
type SizeConfig = internal.SizeConfig
7270

7371
// Deprecated: [v0.123.0] use WithQueueBatch.

0 commit comments

Comments
 (0)