Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all .ts/.js source to eliminate tslint errors and update tslint.json to fine-tune rules #139

Open
VivekMChawla opened this issue Mar 12, 2019 · 0 comments
Open

Refactor all .ts/.js source to eliminate tslint errors and update tslint.json to fine-tune rules #139

VivekMChawla opened this issue Mar 12, 2019 · 0 comments
Assignees
@VivekMChawla
Labels
chore Work that's not a bug or a feature request

Comments

@VivekMChawla
Copy link
Contributor

After installing the TSLint plugin for VS Code, a very large number of tslint errors/warnings came up.

We need to update all .ts/.js source files to match the new rules, or update tslint.json to customize the rules we want enforced for this project.

Long term goal is to enforce our particular tslint rules during automated tests to help ensure code quality and consistency once we get community contributions.
@VivekMChawla VivekMChawla self-assigned this Mar 12, 2019
@VivekMChawla VivekMChawla added the chore Work that's not a bug or a feature request label Mar 12, 2019
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
fix/refactor: Wire up the -f flag in falcon:adk:install
eea1873 
Fixed missing code to make use of the -f flag in falcon:adk:install.
Renamed --configfile flag to --recipefile (single char remains -f).
Cleaned up multiple ts-lint errors/warnings in the files touched
by this fix. Includes updates to tslint rules.

Related to: #139
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(tslint): Modify sfdx-falcon-types
7e4240b 
Commented out a large group of interfaces and types that were not in
use.  Need to decide later whether these are all useless artifacts from
the early days of this project or if the types/interfaces were just
moved to other files.

Related to: #139
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
chore(cleanup): Minor cleanup in Generator files
5465166 
Minor cleanup in files related to Yeoman Generator logic.  Most of these
files already had their big refactoring moments. This commit is mostly
small cleanup items discovered while refactoring the falcon:apk:create
command.

Related to: #22 #139
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Update create/clone commands
976e80a 
Continued refactoring of create/clone commands in an effort to clean up
tslint errors and reduce repetitive code across Generators.

Related to: #22 #139
VivekMChawla added a commit that referenced this issue May 9, 2019
@VivekMChawla
refactor(test): Return test code to normal
d14ec3d 
Update mock input sequence inside create.test.ts. Update testbed ADK
project to use the latest schema for sfdx-project.json. Turn tslint back
on as part of post-test actions.

Related to: #139
VivekMChawla added a commit that referenced this issue May 9, 2019
@VivekMChawla
refactor(tslint): Cleanup of code style issues
2f9f70c 
This is the final batch of fixes to eliminate all tslint errors. Hooray!

Related to: #139
@VivekMChawla VivekMChawla mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VivekMChawla VivekMChawla

Labels
chore Work that's not a bug or a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VivekMChawla