Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all "clone" and "create" commands to use SfdxFalconResult for internal monitoring #22

Open
VivekMChawla opened this issue Aug 26, 2018 · 0 comments
Open

Refactor all "clone" and "create" commands to use SfdxFalconResult for internal monitoring #22

VivekMChawla opened this issue Aug 26, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@VivekMChawla
Copy link
Contributor

Right now, all of the Yeoman-based commands like falcon:demo:clone and falcon:project:create are NOT using the new SfdxFalconResult system to keep track of internal status and return values.

Refactor all Yeoman code to use the new toolset.
@VivekMChawla VivekMChawla added the enhancement New feature or request label Aug 26, 2018
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Create SfdxFalconYeomanGenerator
4df880b 
Create a new abstract class that extends Yeoman's Generator class.  This
new class will standardize a lot of the setup  tasks that are currently
being repeated in each "generator type" class.

Related to: #22
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Update clone-appx-demo-project
38cfa95 
Starting to refactor clone-appx-demo-project.ts and want to have a
safety commit before ripping too many guts out. :-)

Related to: #22 #24
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Generalize Yeoman-related code
a75a8b3 
Complete the core refactor of code to allow for a more generalized
approach to building Yeoman Generators inside SFDX-Falcon. This new code
should dramatically reduce the amount of repeated, boilerplate code when
building Yeoman Generators. This code also wires-in the SfdxFalconResult
object between Command and Generator, as well as uses the latest error
display code.

Related to: #22 #24
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Create inquirer-questions.ts
4bc7c2e 
Create an sfdx-falcon-utility file to centralize development of
functions that build generally reusable Inquirer Question object arrays.
This should allow us to refactor custom Yeoman Generators to remove and
reduce repetitive code.

Related to: #22 #145
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
chore(cleanup): Minor cleanup in Generator files
5465166 
Minor cleanup in files related to Yeoman Generator logic.  Most of these
files already had their big refactoring moments. This commit is mostly
small cleanup items discovered while refactoring the falcon:apk:create
command.

Related to: #22 #139
VivekMChawla added a commit that referenced this issue Apr 6, 2019
@VivekMChawla
refactor(yeoman): Update create/clone commands
976e80a 
Continued refactoring of create/clone commands in an effort to clean up
tslint errors and reduce repetitive code across Generators.

Related to: #22 #139
@VivekMChawla VivekMChawla mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VivekMChawla