cn without clsx package

[danciudev]

Hello,

why are we importing clsx from the clsx package and not directly from class-variance-authority?

According to the documentation on class-variance-authority, cx exports the clsx package but renames it, which would save us a direct dependency https://cva.style/docs/api-reference#cx

import { clsx, type ClassValue } from "clsx"`

to

import type { ClassValue } from 'class-variance-authority/types';
import { cx } from 'class-variance-authority';

[Tiimie1]

first of all bundle size is negligible – clsx is tiny (~240 bytes gzipped)
also many shadcn/ui components don't need variants and don't import class-variance-authority at all. they still need clsx for conditional class merging
your approach would work fine, but than you'd need to install class-variance-authority even on components that dont use variance - and your back to square one

[danciudev]

It doesn’t affect the bundler because it’s imported after cx, so the bundle size would remain the same.

I understand the point, although I suspect there will be very few cases where class-variance-authority isn’t installed, since it’s required if you use the shadcn button.

Perhaps a note in the documentation would be good