Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent math api for quaternion based rotations #25

Open
ccummingsNV opened this issue Jul 2, 2024 · 0 comments
Open

Inconsistent math api for quaternion based rotations #25

ccummingsNV opened this issue Jul 2, 2024 · 0 comments

Comments

@ccummingsNV
Copy link
Collaborator

All the standard matrix_from_X functions, including those that only generate a rotation, return an affine 4x4 transform matrix. However matrix_from_quat returns only a 3x3 rotation matrix.

The float4x4 does have a constructor to go from float3x3, but it's not clear whether this populates m[3][3] with a 1 or not, which would be worth documenting if the intent is simply to convert immediately after use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant