Support BLACK_SCREEN, add format inference, and add new demo #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
kaizhangNV
reviewed
Mar 6, 2025
kaizhangNV
reviewed
Mar 6, 2025
|
|
||
| const static int MAX_BRUSH_SIZE = 16; | ||
|
|
||
| [playground::BLACK_SCREEN(1.0, 1.0)] |
There was a problem hiding this comment.
I'm wondering that if we can extend this attribute to like "COLOR_SCREEN" attribute that we can accept a single color to clear the texture?
There was a problem hiding this comment.
I thought about it but decided against it because:
- People can use a call once shader to set the color anyways
- Color doesn't generalize well to int, uint, or < 3 component textures
- It would require either specifying a color for every texture
It might make sense to have a set of DEFAULT_VALUE_ attributes that can also apply to buffers though...
In which case the attributes should be renamed:
ZEROS->BUFFERBLACK->TEXTUREBLACK_SCREEN->SCREEN_TEXTURE
Devon7925
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #123
closes #119
closes #118
Since the screen size can now be got through measuring the size of a BLACK_SCREEN texture I'm also marking this as
closes #84
This also includes a number of derivative changes for code quality:
outputBufferremoved fromimageMain.slangandprintMain.slang. It wasn't being used.outputTexturesize now controlled fromBLACK_SCREENimageMainandprintMainare now called via attributescomputePipelineas it was no longer necessary due to main entrypoints being called from attributesDeploy: https://devon7925.github.io/slang-playground/