Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in SemanticsDeclBodyVisitor::visitAggTypeDecl #5135

Closed
kaizhangNV opened this issue Sep 23, 2024 · 0 comments
Closed

Refactor code in SemanticsDeclBodyVisitor::visitAggTypeDecl #5135

kaizhangNV opened this issue Sep 23, 2024 · 0 comments
Assignees
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case.

Comments

@kaizhangNV
Copy link
Contributor

Backgroud:

This sub-task is split from #3406.

I wrap up Arial's PR #4854 to a new PR #5107 with some minor issues solved.

However, there still be lots of comments could potential involve large change on this PR.

We should not make one PR has infinitely long conversion and unlimited problems solved, so this task is create to only spot this issue.

Here is the comment:
https://github.com/shader-slang/slang/pull/5107/files/2b6f7a26688b60a74fde979fbfff28a24a493e5c#r1769320448

TLDR: The implementation in SemanticsDeclBodyVisitor::visitAggTypeDecl is lack of readability, it's difficult for anyone to really understand the logic. So we need to refactor the code by splitting the logic into smaller function.

@kaizhangNV kaizhangNV added this to the Q3 2024 (Summer) milestone Sep 23, 2024
@kaizhangNV kaizhangNV self-assigned this Sep 23, 2024
@bmillsNV bmillsNV added the goal:forward looking Feature needed at a later date, not connected to a specific use case. label Sep 26, 2024
@bmillsNV bmillsNV closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:forward looking Feature needed at a later date, not connected to a specific use case.
Projects
None yet
Development

No branches or pull requests

2 participants