Skip to content

[CI] slangpy testing not checking proper backend #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skallweitNV opened this issue Jun 3, 2025 · 3 comments
Open

[CI] slangpy testing not checking proper backend #7316

skallweitNV opened this issue Jun 3, 2025 · 3 comments
Assignees

Comments

@skallweitNV
Copy link
Collaborator

It looks like the slangpy testing doesn't actually update the slang compiler in the slangpy package before running tests, so essentially it runs tests with a very old version of slang (the version shipped with slangpy). I did update to latest slang locally and a lot of slangpy tests were failing (which was easy to fix fortunately) but the fact that the slangpy tests in slang's CI did pass got me worried.

@skallweitNV skallweitNV added the RTR label Jun 3, 2025
@aasgaonkar aasgaonkar self-assigned this Jun 3, 2025
@aasgaonkar
Copy link
Collaborator

looking into this

@aasgaonkar aasgaonkar changed the title [CI] slangpy testing [CI] slangpy testing not checking proper backend Jun 3, 2025
@dryu-nv dryu-nv added this to the Q2 2025 (Spring) milestone Jun 3, 2025
@aasgaonkar
Copy link
Collaborator

is this the expected failure from slangpy 0.30 - https://github.com/shader-slang/slang/actions/runs/15432749878/job/43433440047 ?

@aasgaonkar
Copy link
Collaborator

we have the fix ready: #7334
it is failing CI as expected; we are awaiting a slangpy package update to fix CI bug, then we can merge this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants