-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing Transmuxer test on Safari #7462
Comments
@avelad sent me this additional information:
|
The first 46 frames in the first segment are non-keyframes. That's the only peculiarity I've found so far. The gap at the beginning of the buffered range corresponds to the PTS of the first keyframe. (These data are from the theoplayer URL in the comment above, not the canned data in the failing test case.) |
Just realized why the test case that's failing on Safari isn't failing everywhere.
We don't have native AC3 support in most browsers. So the tests gets skipped on other browsers. |
In the content used in our test case, the first segment starts with a keyframe, but the second does not, and many others do not as well. DTS==PTS in every single frame, so there are no b-frames in that content, nor any chance for us to mistakenly use DTS where we should use PTS or vice-versa. The first gap position (2.08) aligns perfectly with the first frame of the second segment, which is not a keyframe. So the two clips (our test case and the Theoplayer clip) would seem to have some things in common (not every segment starts with a keyframe) and others things differ (Theo's has b-frames). |
This is generating too much noise, and we do not yet know how to fix it. Issue shaka-project#7462
I'm giving up for now. I don't know what to do with this information. I'm hopeful that someone else can make progress with this as a starting place. |
This is generating too much noise, and we do not yet know how to fix it. Issue #7462
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
N/A
What version of Shaka Player are you using?
main
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
N/A: Unit & integration tests
If custom app, can you reproduce the issue using our demo app?
N/A: Unit & integration tests
What browser and OS are you using?
Safari (currently 18.0.1) on macos-latest VMs on GitHub (currently 10.15.7, Arm)
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
N/A: Unit & integration tests
What configuration are you using? What is the output of
player.getNonDefaultConfiguration()
?N/A: Unit & integration tests
What did you do?
Run tests
What did you expect to happen?
Old transmuxer test passes
What actually happened?
Fails with:
As you can see from the buffered ranges, there is a gap of 0.24 seconds between each segment.
I need to dig deeper, but any of these could be true:
I think it's possible that this is a legitimate failure that indicates a real bug, and not just a flaky test. I haven't proven that yet, it's just a gut feeling.
Are you planning send a PR to fix it?
Yes, if I can find the root cause. I would welcome additional help in investigating and in fixing!
The text was updated successfully, but these errors were encountered: