fix(DASH): Fix playback of some DASH with multiple periods #7519
+175
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#7516) With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_() Fixes shaka-project#7516
avelad
requested changes
Oct 29, 2024
Provide an interface between StreamEngine and ManifestParser to defer the call of closeStreamIndex durring the update of segments instead the update of the manifest. Fix eslint / jsdoc
joeyparrish
reviewed
Oct 30, 2024
|
Incremental code coverage: 98.08% |
ncocaign
changed the title
avelad
added
type: bug
avelad
changed the title
tykus160
requested changes
Nov 4, 2024
| @@ -114,6 +114,7 @@ | |||
| +../../lib/util/public_promise.js | |||
| +../../lib/util/state_history.js | |||
| +../../lib/util/stats.js | |||
| +../../lib/util/segment_index.js | |||
There was a problem hiding this comment.
There is already lib/media/segment_index, 2 same file names in different spaces might be confusing
Comment on lines
+124
to
+129
| /** | ||
| * provide CloseSegmentIndexRegister | ||
| * @param {shaka.util.CloseSegmentIndexRegister} register | ||
| * @exportDoc | ||
| */ | ||
| setCloseSegmentIndexRegister(register) {} |
There was a problem hiding this comment.
If we want to add new method to publicly exposed interface, it will need to be documented better.
Preferably though, we shouldn't add new method but try to look for other solutions (maybe callback in shaka.extern.ManifestParser.PlayerInterface?)
Comment on lines
+1507
to
+1509
| * Handles deferred releases of old SegmentIndexes | ||
| * content type from a previous update. | ||
| * @export |
There was a problem hiding this comment.
It's not a part of public interface, don't export it
| * Removes all SegmentReferences that end before the given time. | ||
| * @export | ||
| */ | ||
| evictAll() { |
There was a problem hiding this comment.
If it was exported, it should be defined in shaka.extern.SegmentIndex.
avelad
added
the
status: waiting on response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_()
Fixes #7516