Skip to content

Commit 04f404d

Browse files
committed
fix: add
1 parent e39e622 commit 04f404d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/reusable-node-ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,9 @@ jobs:
7676
pr_reviewer.extra_instructions: |
7777
## Reviewer Instructions
7878
### Unit Tests
79-
- Make sure that the code being tested is not mocked out.
80-
- Make sure that the code being tested is not using any external services.
79+
- Ensure that external API calls or side effects are mocked out, not the function under test
80+
- Each test should import the actual function being tested
81+
- Mock only external dependencies, never the function itself
8182
- Make sure tests cover real functionality, not only type definitions
8283
- `expect()` syntax should be used instead of `assert()`
8384
- If a test is using mocks, ensure its cleaned up after the test

0 commit comments

Comments
 (0)