We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent e39e622 commit 04f404dCopy full SHA for 04f404d
.github/workflows/reusable-node-ci.yml
@@ -76,8 +76,9 @@ jobs:
76
pr_reviewer.extra_instructions: |
77
## Reviewer Instructions
78
### Unit Tests
79
- - Make sure that the code being tested is not mocked out.
80
- - Make sure that the code being tested is not using any external services.
+ - Ensure that external API calls or side effects are mocked out, not the function under test
+ - Each test should import the actual function being tested
81
+ - Mock only external dependencies, never the function itself
82
- Make sure tests cover real functionality, not only type definitions
83
- `expect()` syntax should be used instead of `assert()`
84
- If a test is using mocks, ensure its cleaned up after the test
0 commit comments