Skip to content

Commit 1abf7b1

Browse files
authored
fix: update shardeum package name and add linear linking instructions (#63)
1 parent 141addf commit 1abf7b1

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

.github/workflows/reusable-node-ci.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,14 @@ jobs:
7676
pr_reviewer.extra_instructions: |
7777
## Reviewer Instructions
7878
### General
79-
- In general if there is a PR that requires updating any versions of `@shardeum` packages, ensure those changes are in an separate PR (or in the same PR in its own commit). Otherwise, merging between branch lines (which have different versions) is much more difficult.
79+
- In general if there is a PR that requires updating any versions of `@shardeum-foundation` packages, ensure those changes are in an separate PR (or in the same PR in its own commit). Otherwise, merging between branch lines (which have different versions) is much more difficult.
80+
### Linear Integration
81+
We should make sure that each PR is linked to a Linear issue.
82+
- One of the following must be true:
83+
- The PR description includes the Linear issue key (e.g. `SHARD-123`)
84+
- The PR title includes the Linear issue key (e.g. `P1-123`)
85+
- The PR branch name includes the Linear issue key (e.g. `P1-123`)
86+
- The commit messages include the Linear issue key (e.g. `P1-123`)
8087
### Unit Tests
8188
- Ensure that external API calls or side effects are mocked out, not the function under test
8289
- Each test should import the actual function being tested

0 commit comments

Comments
 (0)