Skip to content

Commit cbcacf6

Browse files
committed
fix: add extra instructions for the pr review agent to make sure the code being tested is not mocked out + add another instruction about not just testing type definitions
1 parent 0c1d748 commit cbcacf6

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/reusable-node-ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,12 @@ jobs:
7373
pr_reviewer.inline_code_comments: "true"
7474
pr_description.publish_description_as_comment: "false"
7575
pr_description.add_original_user_description: "true"
76-
# pr_reviewer.extra_instructions: "- instruction a\n- instruction b\n..."
77-
76+
pr_reviewer.extra_instructions: |
77+
## Reviewer Instructions
78+
### Unit Tests
79+
- Make sure that the code being tested is not mocked out.
80+
- Make sure that the code being tested is not using any external services.
81+
- Make sure tests cover real functionality, not only type definitions
7882
merge-checks:
7983
name: QA merge checks
8084
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)