-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isn't your Benchmark misleading? #1661
Comments
The third bullet point in the features list on the README, explicitly states that the speed is due to being parallelized:
(emphasis mine) find is always single-threaded. Using all of your cores is why fd is faster. |
Well, |
I've heard I've tried both hot cache and cold cache regex searches where Hot cache:
On a hot cache
On a cold cache |
What version is this? Looks like 8.6.0? It would be worth trying a newer version, there are a lot of performance improvements introduced in 9.0.0 |
I've build current master with release target. Here are the results: Hot cache:
Cold cache:
In conclusion, it is true, that current I do agree with the title of the issue: current benchmarks look misleading to me. |
What version of
fd
are you using?fd 10.2.0
As I understood correctly, by default
fd
tries to use all available CPU cores and I think that's most of the benefit that it's getting for better performance.It would be better to explicitly write it in the Benchmark section and also show the comparison when only 1 thread is used via
--threads=1
.The text was updated successfully, but these errors were encountered: